Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Gutter Background, Add Trailing Padding #272

Merged
merged 4 commits into from
Nov 9, 2024

Conversation

thecoolwinter
Copy link
Collaborator

Description

  • Updates the gutter to consider an inset for where to draw it's background.
  • Adds some padding to the trailing edge when line wrap is disabled. This is not an opened issue, but while I was adjusting padding might as well.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

New leading gutter padding, includes some spacing between where the gutter starts to overlap the text and where the gutter is spaced to.

Screen.Recording.2024-11-07.at.10.21.16.PM.mov
Xcode Comparison

Xcode:

Screenshot 2024-11-07 at 9 40 22 PM

CodeEdit:

Screenshot 2024-11-07 at 9 39 34 PM

Added some padding to the trailing edge when line wrap is disabled:

Screenshot 2024-11-07 at 10 18 00 PM

Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-ludwig tom-ludwig merged commit b26a606 into CodeEditApp:main Nov 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Left half of cursor cut off when at beginning of line
3 participants