Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Padding Issue, Assertion Failure On Width Update #53

Merged

Conversation

thecoolwinter
Copy link
Contributor

Description

  • Considers the edge insets when calculating the 'max width' in the layout manager. Fixes a bug where trailing text is clipped when not wrapping lines because the width of the text view is not large enough.
  • Fixes a potential assertion failure when notifying of a width update from the layout manager. Moves the delegate call to outside the protected area so that anything that may need to respond to a width adjustment can cause a layout pass without causing an invalid state.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter added the bug Something isn't working label Nov 8, 2024
@thecoolwinter thecoolwinter merged commit 3ddd279 into CodeEditApp:main Nov 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants