Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Conversation

hamda86
Copy link

@hamda86 hamda86 commented Feb 24, 2023

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name:
  • Your City:
  • Your Slack Name:

Homework Details

  • Module:
  • Week:

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

I fixed all the syntax error.
I solved the error. I used a quote '' INSTEAD of backtick ``
Copy link

@kjjwhitlock kjjwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, Hamda. I like how you have chosen clear labelnames and have paid attention to ensure correct spacing and formatting. Keep it up.

@@ -1,16 +1,18 @@
// There are syntax errors in this code - can you fix it to pass the tests?

function addNumbers(a b c) {
function addNumbers(a, b, c) {
return a + b + c;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

function introduceMe(name, age)
return `Hello, my {name}` is "and I am $age years old`;
function introduceMe(name, age) {
return `Hello, my name is ${name} and I am ${age} years old`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


return "The total is total";
return `The total is ${total}`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

}

function multiply(a, b, c) {
a * b * c;
return;
return a * b * c;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and tidy, like it

@@ -2,15 +2,17 @@
function getRandomNumber() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the comment here to explain what this does?

@@ -2,15 +2,17 @@
function getRandomNumber() {
return Math.random() * 10;
}
//It gives random number between 0 to 10.

// Add comments to explain what this function does. You're meant to use Google!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here too...

// Write the body of this function to concatenate three words together.
// Look at the test case below to understand what this function is expected to return.
return `${firstword} ${secondword} ${thirdword}`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of string interpolation

@@ -5,7 +5,10 @@
Sales tax is 20% of the price of the product.
*/

function calculateSalesTax() {}
function calculateSalesTax(sales) {
const tax = 0.2 * sales;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, clear labelling

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants