-
-
Notifications
You must be signed in to change notification settings - Fork 481
LONDON 10 - Hamda Abdi- JS-CORE-1 - WEEK 1 #529
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,18 @@ | ||
// There are syntax errors in this code - can you fix it to pass the tests? | ||
|
||
function addNumbers(a b c) { | ||
function addNumbers(a, b, c) { | ||
return a + b + c; | ||
} | ||
|
||
function introduceMe(name, age) | ||
return `Hello, my {name}` is "and I am $age years old`; | ||
function introduceMe(name, age) { | ||
return `Hello, my name is ${name} and I am ${age} years old`; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice! |
||
|
||
} | ||
|
||
function getTotal(a, b) { | ||
total = a ++ b; | ||
total = a + b; | ||
|
||
return "The total is total"; | ||
return `The total is ${total}`; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good |
||
} | ||
|
||
/* | ||
|
@@ -24,7 +26,6 @@ To run the tests for just this one file, type `npm test -- --testPathPattern 1-s | |
|
||
=================================================== | ||
*/ | ||
|
||
test("addNumbers adds numbers correctly", () => { | ||
expect(addNumbers(3, 4, 6)).toEqual(13); | ||
}); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,15 @@ | ||
// The syntax for these functions is valid but there are some errors, find them and fix them | ||
|
||
function trimWord(word) { | ||
return wordtrim(); | ||
return word.trim(); | ||
} | ||
|
||
function getStringLength(word) { | ||
return "word".length(); | ||
return word.length; | ||
} | ||
|
||
function multiply(a, b, c) { | ||
a * b * c; | ||
return; | ||
return a * b * c; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice and tidy, like it |
||
} | ||
|
||
/* | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,15 +2,17 @@ | |
function getRandomNumber() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add the comment here to explain what this does? |
||
return Math.random() * 10; | ||
} | ||
//It gives random number between 0 to 10. | ||
|
||
// Add comments to explain what this function does. You're meant to use Google! | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and here too... |
||
function combine2Words(word1, word2) { | ||
return word1.concat(word2); | ||
} | ||
|
||
function concatenate(firstWord, secondWord, thirdWord) { | ||
// It combines 2 words. | ||
function concatenate(firstword, secondword, thirdword) { | ||
// Write the body of this function to concatenate three words together. | ||
// Look at the test case below to understand what this function is expected to return. | ||
return `${firstword} ${secondword} ${thirdword}`; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice use of string interpolation |
||
} | ||
|
||
/* | ||
|
@@ -23,7 +25,6 @@ To run the tests for just this one file, type `npm test -- --testPathPattern 3-f | |
(Reminder: You must have run `npm install` one time before this will work!) | ||
================================== | ||
*/ | ||
|
||
test("concatenate example #1", () => { | ||
expect(concatenate("code", "your", "future")).toEqual("code your future"); | ||
}); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,10 @@ | |
Sales tax is 20% of the price of the product. | ||
*/ | ||
|
||
function calculateSalesTax() {} | ||
function calculateSalesTax(sales) { | ||
const tax = 0.2 * sales; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good, clear labelling |
||
return tax + sales; | ||
} | ||
|
||
/* | ||
CURRENCY FORMATTING | ||
|
@@ -17,7 +20,9 @@ function calculateSalesTax() {} | |
Remember that the prices must include the sales tax (hint: you already wrote a function for this!) | ||
*/ | ||
|
||
function addTaxAndFormatCurrency() {} | ||
function addTaxAndFormatCurrency(sales) { | ||
return "£" + calculateSalesTax(sales).toFixed(2); | ||
} | ||
|
||
/* | ||
=================================================== | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!