West Midlands | Sept-ITP-25 | Mustaf Asani | Sprint 3 | Coursework/sprint 3 practice tdd #813

asaniDev · 2025-10-27T03:02:20Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Created tests to check the expected output of functions before they are created.

…he function that checks for that

…get the ordinal numbers

…t takes in a string and count to create a new string

cjyuan · 2025-10-31T19:29:01Z

Sprint-3/2-practice-tdd/count.js

 function countChar(stringOfCharacters, findCharacter) {
-  return 5
+  let pattern = new RegExp(findCharacter, "g");
+
+  let matchingChars = stringOfCharacters.match(pattern);
+
+  if (matchingChars === null) {
+    return 0;
+  }
+
+  return matchingChars.length;
 }


Does your function returns the value you expect in the following function calls?

countChar("=^.^=", "^"); countChar("=^.^=", ".");

changed the function and used a split method with the findCharacter string literal to avoid special characters like the ones above in regex.

cjyuan · 2025-10-31T19:31:59Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

+  if (num === 1) {
+    return "1st";
+  } else if (num === 2) {
+    return "2nd";
+  } else if (num === 3) {
+    console.log(num);
+    return "3rd";
+  } else if (num > 3 || num < 21) {
+    return `${num}th`;
+  }


For best practices, code submitted to review should be free of debugging code (to keep the code clean).

What should the ordinal numbers of 103, 213, 31 be?

made the function more robust so it can cover more digits and added more tests for different numbers

also removed the use of individual checkers to allow for use with all numbers.

cjyuan · 2025-10-31T19:33:32Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

+test("should return '2nd' for 2", () => {
+  expect(getOrdinalNumber(2)).toEqual("2nd");
+});
+
+test("should return '3rd' for 3", () => {
+  expect(getOrdinalNumber(3)).toEqual("3rd");


To ensure thorough testing, we need broad scenarios that cover all possible cases.
Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories.
Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.

For example, we can prepare a test for numbers 2, 22, 132, etc. as

test("append 'nd' to numbers ending in 2, except those ending in 12", () => { expect( getOrdinalNumber(2) ).toEqual("2nd"); expect( getOrdinalNumber(22) ).toEqual("22nd"); expect( getOrdinalNumber(132) ).toEqual("132nd"); });

Can you make the tests in this script more comprehensive?

added more tests in each suite to make the tests look at a wide variety of numbers

cjyuan · 2025-10-31T19:34:28Z

Sprint-3/2-practice-tdd/repeat.js

+  if (count === 0) {
+    return newStr;
+  } else if (count === 1) {
+    return (newStr += str);


Why not just return str directly?

returned string directly only when count = 1

cjyuan · 2025-10-31T19:35:11Z

Sprint-3/2-practice-tdd/repeat.js

+  } else {
+    return "Error invalid count used, please use integers from 0 upwards.";
+  }


How would the caller distinguish the result of the following two function calls?

repeat("Error invalid count used, please use integers from 0 upwards.", 1)

repeat("", -1)

Both function calls return the same value.

If the input is invalid (negative integers), how can we tell the user that there's an issue instead of returning a response?

cjyuan · 2025-10-31T19:35:39Z

Sprint-3/2-practice-tdd/repeat.test.js

+  expect(repeatedStr).toEqual(
+    "Error invalid count used, please use integers from 0 upwards."
+  );


If you modified repeat() to throw an error when count is negative, and you wanted to test if the function can throw an error as expected, you can use .toThrow(). You can find out more about how to use .toThrow() here: https://jestjs.io/docs/expect#tothrowerror (Note: Pay close attention to the syntax of the example)

used to throw function to test if an invalid value had been input.

…s to count test file

…sts to check that different numbers work

…n error

cjyuan · 2025-11-21T16:56:07Z

Did you forget to push the changes to GitHub?

wahibkamran · 2025-11-22T14:04:31Z

Sprint-3/2-practice-tdd/repeat.js

+  } else {
+    return "Error invalid count used, please use integers from 0 upwards.";
+  }


If the input is invalid (negative integers), how can we tell the user that there's an issue instead of returning a response?

cjyuan · 2025-11-22T22:36:16Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

-    return "3rd";
-  } else if (num > 3 || num < 21) {
-    return `${num}th`;
+  const lastDigit = num.toString()[num.toString().length - 1];


Could consider using the more efficient approach involving the % operator to extract the last digit and the last two digits from a number directly.

cjyuan · 2025-11-22T22:44:41Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

+test("should append 'st' to numbers with 1 at the end except for those ending with 11", () => {
  expect(getOrdinalNumber(1)).toEqual("1st");
+  expect(getOrdinalNumber(21)).toEqual("21st");
+  expect(getOrdinalNumber(101)).toEqual("101st");
+  expect(getOrdinalNumber(151)).toEqual("151st");
+  expect(getOrdinalNumber(2061)).toEqual("2061st");
 });

-test("should return '2nd' for 2", () => {
+test("should append 'nd' to numbers with 2 at the end except for those ending with 12", () => {
  expect(getOrdinalNumber(2)).toEqual("2nd");
+  expect(getOrdinalNumber(22)).toEqual("22nd");
+  expect(getOrdinalNumber(342)).toEqual("342nd");
+  expect(getOrdinalNumber(592)).toEqual("592nd");
+  expect(getOrdinalNumber(1972)).toEqual("1972nd");
 });

-test("should return '3rd' for 3", () => {
+test("should append 'rd' to numbers with 3 at the end except for those ending with 13", () => {
  expect(getOrdinalNumber(3)).toEqual("3rd");
+  expect(getOrdinalNumber(33)).toEqual("33rd");
+  expect(getOrdinalNumber(353)).toEqual("353rd");
+  expect(getOrdinalNumber(93)).toEqual("93rd");
+  expect(getOrdinalNumber(783)).toEqual("783rd");
 });

-test("should return any number between 4 and 20 with a suffix of 'th' at end of number", () => {
+test("should append 'th' to all other numbers which do not end in 1,2,3,11,12 or 13", () => {
  expect(getOrdinalNumber(10)).toEqual("10th");
+  expect(getOrdinalNumber(11)).toEqual("11th");
+  expect(getOrdinalNumber(212)).toEqual("212th");
+  expect(getOrdinalNumber(113)).toEqual("113th");
+  expect(getOrdinalNumber(17)).toEqual("17th");
 });


These tests are quite comprehensive. If you use this test script to test your implementation, you can discover some bug in your code.

cjyuan · 2025-11-22T22:56:27Z

Sprint-3/2-practice-tdd/repeat.js

+    );
+    //return "Error invalid count used, please use integers from 0 upwards.";
  }
+  return true;


What's the purpose of the statement on line 19? When do you expect it to be executed?

You can also consider structuring your code in the following way:

if (code < 0) throw ... if (code == 0) return ""; if (code == 1) return ...; let newStr = ""; ... return newStr;

or (if you don't mind trading performance for simpler code)

if (count < 0) throw ...; // this code will produce the correct result for any count >= 0 anyway. let newStr = ""; ... return newstr;

asaniDev added 4 commits October 27, 2025 01:15

added tests for multiple occurences and for no occurances then made t…

c518625

…he function that checks for that

fixed a testing error

51060d9

added tests for ordinal numbers up to 20, then created a function to …

1a6131d

…get the ordinal numbers

added tests for the given scenarios and created a repeat function tha…

83c98dc

…t takes in a string and count to create a new string

asaniDev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 27, 2025

cjyuan reviewed Oct 31, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 31, 2025

asaniDev added 3 commits November 19, 2025 02:30

changed the function countChar to use split method, added a more test…

752f7ae

…s to count test file

made the function more generic to cover all numbers and added more te…

f04aba1

…sts to check that different numbers work

added a new way of catching error by throwing and testing for a throw…

d754f5a

…n error

asaniDev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 21, 2025

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 21, 2025

asaniDev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 22, 2025

wahibkamran suggested changes Nov 22, 2025

View reviewed changes

wahibkamran removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 22, 2025

cjyuan reviewed Nov 22, 2025

View reviewed changes

Uh oh!

West Midlands | Sept-ITP-25 | Mustaf Asani | Sprint 3 | Coursework/sprint 3 practice tdd #813

Are you sure you want to change the base?

West Midlands | Sept-ITP-25 | Mustaf Asani | Sprint 3 | Coursework/sprint 3 practice tdd #813

Uh oh!

Conversation

asaniDev commented Oct 27, 2025

Learners, PR Template

Changelist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Nov 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants