generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 244
West Midlands | Sept-ITP-25 | Mustaf Asani | Sprint 3 | Coursework/sprint 3 practice tdd #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asaniDev
wants to merge
7
commits into
CodeYourFuture:main
Choose a base branch
from
asaniDev:coursework/sprint-3-practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c518625
added tests for multiple occurences and for no occurances then made t…
asaniDev 51060d9
fixed a testing error
asaniDev 1a6131d
added tests for ordinal numbers up to 20, then created a function to …
asaniDev 83c98dc
added tests for the given scenarios and created a repeat function tha…
asaniDev 752f7ae
changed the function countChar to use split method, added a more test…
asaniDev f04aba1
made the function more generic to cover all numbers and added more te…
asaniDev d754f5a
added a new way of catching error by throwing and testing for a throw…
asaniDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| const totalChar = stringOfCharacters.split(findCharacter); | ||
|
|
||
| return totalChar.length - 1; | ||
| } | ||
|
|
||
| module.exports = countChar; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,33 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| const lastDigit = num.toString()[num.toString().length - 1]; | ||
|
|
||
| if (lastDigit === "1") { | ||
| if (num === 11) { | ||
| return `${num}th`; | ||
| } | ||
|
|
||
| return `${num}st`; | ||
| } else if (lastDigit === "2") { | ||
| if (num.toString().length > 1) { | ||
| const last2Digits = num.toString().slice(-2); | ||
|
|
||
| if (last2Digits === "12") { | ||
| return `${num}th`; | ||
| } | ||
| } | ||
| return `${num}nd`; | ||
| } else if (lastDigit === "3") { | ||
| if (num.toString().length > 1) { | ||
| const last2Digits = num.toString().slice(-2); | ||
|
|
||
| if (last2Digits === "13") { | ||
| return `${num}th`; | ||
| } | ||
| } | ||
| return `${num}rd`; | ||
| } | ||
|
|
||
| return `${num}th`; | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could consider using the more efficient approach involving the
%operator to extract the last digit and the last two digits from a number directly.