West Midlands | Sept-ITP-25 | Mustaf Asani | Sprint 3 | Coursework/sprint 3 practice tdd #813

asaniDev · 2025-10-27T03:02:20Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Created tests to check the expected output of functions before they are created.

…he function that checks for that

…get the ordinal numbers

…t takes in a string and count to create a new string

Sprint-3/2-practice-tdd/count.js

Sprint-3/2-practice-tdd/get-ordinal-number.js

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

Sprint-3/2-practice-tdd/repeat.js

cjyuan · 2025-10-31T19:35:11Z

Sprint-3/2-practice-tdd/repeat.js

+  } else {
+    return "Error invalid count used, please use integers from 0 upwards.";
+  }


How would the caller distinguish the result of the following two function calls?

repeat("Error invalid count used, please use integers from 0 upwards.", 1)

repeat("", -1)

Both function calls return the same value.

If the input is invalid (negative integers), how can we tell the user that there's an issue instead of returning a response?

Sprint-3/2-practice-tdd/repeat.test.js

…s to count test file

…sts to check that different numbers work

…n error

cjyuan · 2025-11-21T16:56:07Z

Did you forget to push the changes to GitHub?

wahibkamran · 2025-11-22T14:04:31Z

Sprint-3/2-practice-tdd/repeat.js

+  } else {
+    return "Error invalid count used, please use integers from 0 upwards.";
+  }


If the input is invalid (negative integers), how can we tell the user that there's an issue instead of returning a response?

cjyuan · 2025-11-22T22:36:16Z

Sprint-3/2-practice-tdd/get-ordinal-number.js

-    return "3rd";
-  } else if (num > 3 || num < 21) {
-    return `${num}th`;
+  const lastDigit = num.toString()[num.toString().length - 1];


Could consider using the more efficient approach involving the % operator to extract the last digit and the last two digits from a number directly.

used the % to have less code and less function calls

cjyuan · 2025-11-22T22:44:41Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

+test("should append 'st' to numbers with 1 at the end except for those ending with 11", () => {
  expect(getOrdinalNumber(1)).toEqual("1st");
+  expect(getOrdinalNumber(21)).toEqual("21st");
+  expect(getOrdinalNumber(101)).toEqual("101st");
+  expect(getOrdinalNumber(151)).toEqual("151st");
+  expect(getOrdinalNumber(2061)).toEqual("2061st");
 });

-test("should return '2nd' for 2", () => {
+test("should append 'nd' to numbers with 2 at the end except for those ending with 12", () => {
  expect(getOrdinalNumber(2)).toEqual("2nd");
+  expect(getOrdinalNumber(22)).toEqual("22nd");
+  expect(getOrdinalNumber(342)).toEqual("342nd");
+  expect(getOrdinalNumber(592)).toEqual("592nd");
+  expect(getOrdinalNumber(1972)).toEqual("1972nd");
 });

-test("should return '3rd' for 3", () => {
+test("should append 'rd' to numbers with 3 at the end except for those ending with 13", () => {
  expect(getOrdinalNumber(3)).toEqual("3rd");
+  expect(getOrdinalNumber(33)).toEqual("33rd");
+  expect(getOrdinalNumber(353)).toEqual("353rd");
+  expect(getOrdinalNumber(93)).toEqual("93rd");
+  expect(getOrdinalNumber(783)).toEqual("783rd");
 });

-test("should return any number between 4 and 20 with a suffix of 'th' at end of number", () => {
+test("should append 'th' to all other numbers which do not end in 1,2,3,11,12 or 13", () => {
  expect(getOrdinalNumber(10)).toEqual("10th");
+  expect(getOrdinalNumber(11)).toEqual("11th");
+  expect(getOrdinalNumber(212)).toEqual("212th");
+  expect(getOrdinalNumber(113)).toEqual("113th");
+  expect(getOrdinalNumber(17)).toEqual("17th");
 });


These tests are quite comprehensive. If you use this test script to test your implementation, you can discover some bug in your code.

added code to catch negative and non-integer values

cjyuan · 2025-11-22T22:56:27Z

Sprint-3/2-practice-tdd/repeat.js

+    );
+    //return "Error invalid count used, please use integers from 0 upwards.";
  }
+  return true;


What's the purpose of the statement on line 19? When do you expect it to be executed?

You can also consider structuring your code in the following way:

if (code < 0) throw ... if (code == 0) return ""; if (code == 1) return ...; let newStr = ""; ... return newStr;

or (if you don't mind trading performance for simpler code)

if (count < 0) throw ...; // this code will produce the correct result for any count >= 0 anyway. let newStr = ""; ... return newstr;

refactored the code to reduce the number of if else statements.

… for negative and non integer numbers

cjyuan

There is a bug in the getOrdinalNumber(). Other changes look good.

cjyuan · 2025-11-24T22:30:01Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

+test("should append 'th' to all other numbers which do not end in 1,2,3,11,12 or 13", () => {
+  expect(getOrdinalNumber(0)).toEqual("0th");
+  expect(getOrdinalNumber(11)).toEqual("11th");
+  expect(getOrdinalNumber(212)).toEqual("212th");
+  expect(getOrdinalNumber(113)).toEqual("113th");
+  expect(getOrdinalNumber(17)).toEqual("17th");
+});


If you add enough samples in this categories, you may discover a bug in your implementation.

asaniDev added 4 commits October 27, 2025 01:15

added tests for multiple occurences and for no occurances then made t…

c518625

…he function that checks for that

fixed a testing error

51060d9

added tests for ordinal numbers up to 20, then created a function to …

1a6131d

…get the ordinal numbers

added tests for the given scenarios and created a repeat function tha…

83c98dc

…t takes in a string and count to create a new string

asaniDev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 27, 2025

cjyuan reviewed Oct 31, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 31, 2025

asaniDev added 3 commits November 19, 2025 02:30

changed the function countChar to use split method, added a more test…

752f7ae

…s to count test file

made the function more generic to cover all numbers and added more te…

f04aba1

…sts to check that different numbers work

added a new way of catching error by throwing and testing for a throw…

d754f5a

…n error

asaniDev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 21, 2025

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 21, 2025

asaniDev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 22, 2025

wahibkamran suggested changes Nov 22, 2025

View reviewed changes

wahibkamran removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 22, 2025

cjyuan reviewed Nov 22, 2025

View reviewed changes

asaniDev added 4 commits November 24, 2025 14:48

used a simpler % test to get the last digits of a number, added tests…

af1e37a

… for negative and non integer numbers

removed trailing return = true that was not doing anything

fea77f0

removed unnecessary code from function

eac5a16

refactored test for 0 count to use toBe

aec1685

asaniDev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 24, 2025

cjyuan reviewed Nov 24, 2025

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 24, 2025

Uh oh!

West Midlands | Sept-ITP-25 | Mustaf Asani | Sprint 3 | Coursework/sprint 3 practice tdd #813

Are you sure you want to change the base?

West Midlands | Sept-ITP-25 | Mustaf Asani | Sprint 3 | Coursework/sprint 3 practice tdd #813

Uh oh!

Conversation

asaniDev commented Oct 27, 2025

Learners, PR Template

Changelist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan commented Nov 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants