-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add entry for SwiftUI Spacer #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SSwiniarski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlewr I did a first review and left a few comments, all of which are fairly minor. (Mostly the fact we only bold the fist instance of a term, and in the rest of the entry just highlight keywords with single backticks.)
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
|
Thanks @SSwiniarski for reviewing! I think I've added all the changes. Let me know if anything else is required. :) |
SSwiniarski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlewr Looks good for a second review.
|
Hey @gracekishino ! Would you be comfortable taking this entry on for a second review? |
@yangc95 yes I'd love to try it! |
|
I took a look through and this looks like a great entry to me! @yangc95 The only comment I have is, do we usually not have the |
|
👋 @jlewr |
|
@jlewr live link: https://www.codecademy.com/resources/docs/swiftui/views/spacer
It looks as if you're anonymous. If you want to be credited, see My contribution is live but I’m not being shown as a contributor, why is this? cc: @SSwiniarski |

Description
Added an entry for the Spacer view in SwiftUI, including syntax, examples and images.
Type of Change
Checklist
mainbranch.