Skip to content

Conversation

@jlewr
Copy link
Contributor

@jlewr jlewr commented May 15, 2023

Description

Added an entry for the Spacer view in SwiftUI, including syntax, examples and images.

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@CLAassistant
Copy link

CLAassistant commented May 15, 2023

CLA assistant check
All committers have signed the CLA.

@jlewr jlewr changed the title Swift spacer Add entry for SwiftUI Spacer May 15, 2023
@jlewr jlewr mentioned this pull request May 15, 2023
3 tasks
@SSwiniarski SSwiniarski linked an issue May 19, 2023 that may be closed by this pull request
3 tasks
@SSwiniarski SSwiniarski self-assigned this May 19, 2023
@SSwiniarski SSwiniarski added new entry New entry or entries swiftui status: under review Issue or PR is currently being reviewed labels May 19, 2023
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlewr I did a first review and left a few comments, all of which are fairly minor. (Mostly the fact we only bold the fist instance of a term, and in the rest of the entry just highlight keywords with single backticks.)

SSwiniarski and others added 10 commits May 19, 2023 12:47
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
@jlewr
Copy link
Contributor Author

jlewr commented May 19, 2023

Thanks @SSwiniarski for reviewing! I think I've added all the changes. Let me know if anything else is required. :)

Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlewr Looks good for a second review.

@yangc95
Copy link
Contributor

yangc95 commented May 31, 2023

Hey @gracekishino ! Would you be comfortable taking this entry on for a second review?

@gracekishino
Copy link
Contributor

Hey @gracekishino ! Would you be comfortable taking this entry on for a second review?

@yangc95 yes I'd love to try it!

@gracekishino
Copy link
Contributor

I took a look through and this looks like a great entry to me!

@yangc95 The only comment I have is, do we usually not have the body view code in syntax blocks?

@yangc95 yangc95 self-assigned this Jun 21, 2023
@yangc95 yangc95 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jun 21, 2023
@yangc95 yangc95 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jun 23, 2023
@yangc95 yangc95 merged commit e9ca4fd into Codecademy:main Jun 23, 2023
@github-actions
Copy link

👋 @jlewr
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

@yangc95
Copy link
Contributor

yangc95 commented Jun 23, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Term Entry] SwiftUI Views Spacer()

5 participants