Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support size label customization #26

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Support size label customization #26

merged 2 commits into from
Sep 20, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 13, 2021

Closes #25

@JavierCane
Copy link
Member

Thx for the contribution!

Please, give us some time to review it. However, in order to provide quick feedback, the feature totally makes sense, so you can assume that it will be merged 😊

@ahopkins
Copy link

I am looking to add an action for labeling the size of the PR. I see there are a few options on the marketplace. Seeing this PR is about to be merged makes my decision to use this tool. Looking forward to it!

Prevents issues with $10 and higher.
@bflad
Copy link
Contributor Author

bflad commented Jun 1, 2021

Pushed up fix for positional arguments to use curly braces, since anything above $9 can incorrectly expand (e.g. $10 -> $1 appended with a 0 character).

Copy link
Member

@rgomezcasas rgomezcasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot and sorry for the delay reviewing it!! 👌👏

@rgomezcasas rgomezcasas merged commit 2b4112f into CodelyTV:master Sep 20, 2021
@rgomezcasas
Copy link
Member

Released in v1 and v1.7.0. Thanks!!! 😊

bflad added a commit to hashicorp/terraform-provider-external that referenced this pull request Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26

The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad added a commit to hashicorp/terraform-provider-http that referenced this pull request Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26

The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad added a commit to hashicorp/terraform-provider-local that referenced this pull request Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26

The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad added a commit to hashicorp/terraform-provider-null that referenced this pull request Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26

The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad added a commit to hashicorp/terraform-provider-random that referenced this pull request Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26

The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad added a commit to hashicorp/terraform-provider-tls that referenced this pull request Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26

The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad added a commit to hashicorp/terraform-provider-external that referenced this pull request Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26

The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad added a commit to hashicorp/terraform-provider-http that referenced this pull request Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26

The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad added a commit to hashicorp/terraform-provider-local that referenced this pull request Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26

The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad added a commit to hashicorp/terraform-provider-null that referenced this pull request Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26

The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad added a commit to hashicorp/terraform-provider-random that referenced this pull request Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26

The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
bflad added a commit to hashicorp/terraform-provider-tls that referenced this pull request Aug 19, 2022
Reference: CodelyTV/pr-size-labeler#26

The customization capabilities were merged awhile ago, but switching this back to upstream was missed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Size Label Customization
4 participants