-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the discovery.xml fetching #56
Comments
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
…ion, drop constructor.
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
…ad of strrpos().
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
…get discovery. It can happen that file_get_contents() hangs at the end of a stream, waiting for more data. With curl it seems this does not happen. Even better would be to use e.g. Guzzle http client, but that's too big a change for now.
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
…ds in CoolRequest.
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
…from getDiscovery().
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
donquixote
added a commit
to donquixote/collabora-drupal
that referenced
this issue
Nov 12, 2024
…ad of strrpos().
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
…t in ViewerController. Also make the private property protected.
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
donquixote
added a commit
that referenced
this issue
Dec 3, 2024
…uest Issue #56: Refactor CoolRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have the
CoolRequest
class which fetches thediscovery.xml
and extracts the WOPI client url from the xml.I would like to refactor this.
Refactoring:
Functional changes:
t()
strings, and rethink error message passing.@hfiguiere some questions.
In
CoolRequest
we have these error codes 101, 201 etc.Do these numbers have special meanings? Is there any external system that understands these number codes?
The text was updated successfully, but these errors were encountered: