Issue CollaboraOnline#56: Convert CoolRequest into a service.

collabora_online.services.yml

@@ -0,0 +1,4 @@
+services:
+  _defaults:
+    autowire: true
+  Drupal\collabora_online\Cool\CoolRequest: { }

src/Cool/CoolRequest.php

@@ -85,7 +85,7 @@ function strStartsWith($s, $ss) {
 }
 
 /**
- * Helper class to fetch a WOPI client url.
+ * Service to fetch a WOPI client url.
  */
 class CoolRequest {
 

src/Cool/CoolUtils.php

@@ -248,9 +248,9 @@ public static function getViewerRender(Media $media, bool $can_write, $options =
         $wopi_base = $default_config->get('cool')['wopi_base'];
         $allowfullscreen = $default_config->get('cool')['allowfullscreen'] ?? FALSE;
 
-        $req = new CoolRequest();
+        $discovery_xml_service = \Drupal::service(CoolRequest::class);
         try {
-            $wopi_client = $req->getWopiClientURL();
+            $wopi_client = $discovery_xml_service->getWopiClientURL();
         }
         catch (CoolRequestException $e) {
             return [

tests/src/ExistingSite/FetchClientUrlTestDISABLED.php

@@ -16,7 +16,7 @@ class FetchClientUrlTestDISABLED extends ExistingSiteBase {
      * Tests fetching the client url.
      */
     public function testFetchClientUrl(): void {
-        $cool_request = new CoolRequest();
+        $cool_request = $this->service(CoolRequest::class);
         $client_url = $cool_request->getWopiClientURL();
         // The protocol, domain and port are known when this test runs in the
         // docker-compose setup.
@@ -27,11 +27,30 @@ public function testFetchClientUrl(): void {
      * Tests error behavior when fetching client url.
      */
     public function testFetchClientUrlError(): void {
-        $cool_request = new CoolRequest();
+        $cool_request = $this->service(CoolRequest::class);
         $client_url = $cool_request->getWopiClientURL();
         // The protocol, domain and port are known when this test runs in the
         // docker-compose setup.
         $this->assertMatchesRegularExpression('@^http://collabora\.test:9980/browser/[0-9a-f]+/cool\.html\?$@', $client_url);
     }
 
+    /**
+     * Gets a service that is instance of a specific class.
+     *
+     * This is better for static analysis than \Drupal::service().
+     *
+     * @template T of object
+     *
+     * @param class-string<T> $class
+     *   The service class or interface, which is also used as the service id.
+     *
+     * @return T&object
+     *   The service instance.
+     */
+    protected function service(string $class): object {
+        $service = \Drupal::service($class);
+        $this->assertInstanceOf($class, $service);
+        return $service;
+    }
+
 }