[Fix] Resolve Logistics Vehicle Group-Based Access

[dgibso29]

Pull Request Description

When merged this pull request will:

• Resolve [Bug] "ADD_GROUP" Logi Vehicle Macro Does Not Work #181
• No longer ignore group-based access checks for logistics vehicles.

Release Notes

• Group-based Logistics Vehicle access will now work properly. Any player in a Group with access will now receive it, regardless of their role. In the default framework config, this is any member of COMMAND or ZEUS.

IMPORTANT

• Testing has been completed as neccessary, depending on the nature & impact of the changes.
• The Release Notes section below must be filled out appropriately to explain the changes made in this PR. This section will be used in Framework Changelogs.
• If the contribution affects the wiki, please include your changes in this pull request so the wiki is consistently updated.
• Contribution Guidelines are read, understood and applied.
• Title of this PR uses our standard template [Descriptor] - Add|Fix|Improve|Change|Make|Remove {changes}.

[dgibso29]

Rare @Bubbus skill issue

[dgibso29]

Previously, the access check would break out if the player did not have role based access, instead of breaking out if they DID have access.

Now it will break out if they have access, or continue to the Group-based check.

[dgibso29]

Inverted the logic to make it easier to understand. Defaults to true. If they have role access -- great, still true, we break out true. If not, _passedCheck turns false and we move on the the group access check. Finally, we return the value of that check.

[Bubbus]

very poggers my epic chungus

[Cre8or]

Looks good, sounds good, feels good.

🚢