[Feature] Make unit-classnames usable in gearscript (for non-player units only). #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joecuronium
reviewed
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #104
Pull Request Description
When merged this pull request will:
Release Notes
Can now use unit classnames in gearscript (for non-player units only).
IMPORTANT
Testing has been completed as neccessary, depending on the nature & impact of the changes.
This changes a fundamental feasure so it needs extensive pre-release testing.
The Release Notes section below must be filled out appropriately to explain the changes made in this PR. This section will be used in Framework Changelogs.
If the contribution affects the wiki, please include your changes in this pull request so the wiki is consistently updated.
Contribution Guidelines are read, understood and applied.
Title of this PR uses our standard template
[Descriptor] - Add|Fix|Improve|Change|Make|Remove {changes}.