remove a bunch of ramda #964
Conversation
There was a problem hiding this comment.
So far, this is great work @hejkal, thank you so much!
I've got some more to look through but I think this PR is actually too big already. The lack of front end and integration tests makes this really hard to guarantee we're not breaking anything. It's obviously good practice in general but given that it's open source, we have a secondary reason: if I (or theoretically anyone) wants to upstream any of the work, it becomes harder to manage cherry-picking. As I often say, doing things in the open incentivizes good engineering practices 😄
All that said, outside of a few things I've mentioned, I don't think it make sense to do go back and separate this all. Let's wrap up the work that's already been done and do additional changes in separate, more easily digestable and potentially reusable PRs.
| const emailLists$ = flyd.map(R.prop('body'), request({method: 'get', path: pathPrefix + '/email_lists'}).load) | ||
| state.selectedTagMasterIds$ = flyd.map(R.map(ls => ls.tag_master_id), emailLists$) | ||
| const emailLists$ = flyd.map(r => r.body, request({method: 'get', path: pathPrefix + '/email_lists'}).load) | ||
| state.selectedTagMasterIds$ = flyd.map(emailLists$.map(ls => ls.tag_master_id)) |
There was a problem hiding this comment.
Can you say more about what looks wrong here? As far as I can tell it's the same as other similar places, switching from R.prop('thing') to i => i.thing and from R.map(f, thing) to thing.map(f)
hejkal
force-pushed
the
moving-away-from-ramda
branch
from
4421251 to
3316d90
Compare
hejkal
force-pushed
the
moving-away-from-ramda
branch
from
02415bf to
b6f19fd
Compare
|
closing this because I split it out into smaller chunks |
NOTE: DO NOT discuss internal CommitChange information in your PR; this PR will be public.
Link back to the issue in the Tix repo when you need to do that.