New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup class-object #966

Merged

wwahammy merged 1 commit into supporter_level_goal from cleanup-class-object

Dec 16, 2024

hejkal commented Dec 16, 2024

from this discussion:
#964 (comment)

other options:

I could move text-input to search.js, since it's only used there, either as a function or just inline its contents


          remove unused class-object and the unused things it was imported in

e060948

hejkal requested a review from wwahammy as a code owner

December 16, 2024 17:34

hejkal mentioned this pull request

remove a bunch of ramda #964

Closed

wwahammy approved these changes

View reviewed changes

Member

wwahammy left a comment

Looks good!

I'd prefer not to inline, there's WAY too many things inlined already so breaking up is helpful.

wwahammy merged commit 9631b10 into supporter_level_goal

5 checks passed

wwahammy deleted the cleanup-class-object branch

December 16, 2024 18:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet