Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expander #138

Closed
wants to merge 1 commit into from
Closed

Expander #138

wants to merge 1 commit into from

Conversation

VladislavAntonyuk
Copy link
Collaborator

Fixes

#109

Description

Add expander

Detailed Solution

Port expander from XCT to MCT

@brminnick
Copy link
Collaborator

brminnick commented Oct 12, 2021 •
edited
Loading

Hi @VladislavAntonyuk! Thanks for submitting this PR, but I have to close it for now because its Proposal hasn't yet been approved.

We have a new contribution process (outlined in the README) where a Proposal must first be approved before we can accept PRs adding it to the Toolkit. We delve deeper into the new process in our latest Community Stand-up.

Once the Proposal has been both Championed and Approved, we'll be happy to re-open this PR!

@brminnick brminnick closed this Oct 12, 2021
@emorell96
Copy link

So will this ever be revived? Or the whole XCT won't be fully ported unless it goes through all the bureaucracy even it was actually implemented?

@VladislavAntonyuk
Copy link
Collaborator Author

@emorell96 it will after the proposal is approved. We will back to it later after GA.

softlion added a commit to softlion/CommunityToolkitMaui that referenced this pull request Apr 14, 2023
@softlion
fix CommunityToolkit#138
3daea01
softlion added a commit to softlion/CommunityToolkitMaui that referenced this pull request Apr 19, 2023
@softlion
fix CommunityToolkit#138
4f0cfd5
VladislavAntonyuk added a commit that referenced this pull request May 2, 2023
@softlion @VladislavAntonyuk
fix #1138 File saver and Folder picker (#1142)
77213ae 
* fix #138

* Is not null, fix disposable

---------

Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com>
Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VladislavAntonyuk @brminnick @emorell96