Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1138 File saver and Folder picker #1142

Merged
merged 3 commits into from
May 2, 2023

Conversation

softlion
Copy link
Contributor

@softlion softlion commented Apr 14, 2023

Description of Change

Fix issue #1138 by using the correct method to get a UIController where to display the picker.

Also prevent future potential app freeze by making sure the TaskCompletionSource won't wait on nothing.

Linked Issues

Fixes #1138 , #1145

PR Checklist

Additional information

@MartyIX
Copy link
Contributor

MartyIX commented Apr 19, 2023

(Maybe you would be interested in taking a look at dotnet/maui#13814 and suggesting how to fix it properly there given you understand this topic. 🙏)

@VladislavAntonyuk VladislavAntonyuk enabled auto-merge (squash) May 2, 2023 08:19
@VladislavAntonyuk VladislavAntonyuk merged commit 77213ae into CommunityToolkit:main May 2, 2023
@softlion softlion deleted the fix/issue138 branch May 2, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] FileSaver on iOS crashing when started from a modal
3 participants