Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker on Mac Catalyst does not always return the file picked #13814

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

MartyIX
Copy link
Contributor

@MartyIX MartyIX commented Mar 10, 2023

Description of Change

I'm creating this PR just to spark some discussion about the #11088 issue. The removed lines fixed the issue for me (on Mac Ventura 13.1 arm64). The reason why #11088 happens is because the two delegates compete with each other and if this delegate wins, then no file is picked.

I don't have deeper understanding of the code so that's as much as I know. Also I don't have an iOS device/environment at my disposal to really test it. I tested it only on Mac Ventura 13.1.

Anyway, my hope is that someone will know how to finish this PR.

Issues Fixed

Fixes #11088

@ghost ghost added the community ✨ Community Contribution label Mar 10, 2023
@ghost
Copy link

ghost commented Mar 10, 2023

Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Eilon Eilon added the area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info label Mar 10, 2023
@MartyIX MartyIX force-pushed the feature/filepicker-maccatalyst branch from b5c1ff9 to 1f2e294 Compare March 11, 2023 16:45
@MartyIX MartyIX changed the title [NO MERGE] FilePicker on Mac Catalyst does not always return the file picked FilePicker on Mac Catalyst does not always return the file picked Mar 11, 2023
@MartyIX MartyIX marked this pull request as ready for review March 13, 2023 08:18
@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mattleibow mattleibow self-requested a review March 13, 2023 19:01
@mattleibow mattleibow self-assigned this Mar 13, 2023
@rmarinho
Copy link
Member

I actually faced this issue the other day too.

@rmarinho rmarinho merged commit 439d6e6 into dotnet:main Jun 19, 2023
@MartyIX MartyIX deleted the feature/filepicker-maccatalyst branch June 19, 2023 11:18
@MartyIX
Copy link
Contributor Author

MartyIX commented Jun 19, 2023

@rmarinho I did not expect that this would get merged but I'm happy if the patch is actually correct.

Anyway, would you consider adding the suggested backport label?

@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.6.8686 Look for this fix in 8.0.0-preview.6.8686! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info community ✨ Community Contribution fixed-in-8.0.0-preview.6.8686 Look for this fix in 8.0.0-preview.6.8686!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FilePicker on MacOS does not always return the file picked
5 participants