Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking the information button in the sample app crashes the app #3834

Closed
2 tasks done
huynhsontung opened this issue Mar 12, 2021 · 4 comments · Fixed by #3837
Closed
2 tasks done

Clicking the information button in the sample app crashes the app #3834

huynhsontung opened this issue Mar 12, 2021 · 4 comments · Fixed by #3837
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 sample app 🖼 sample bug 🐛
Milestone
7.0.1

Comments

@huynhsontung
Copy link
Contributor

huynhsontung commented Mar 12, 2021 •
edited
Loading

Describe the bug

Clicking the information button on the menu item crashes the sample app.

  • Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work: v6.1

Steps to Reproduce

  • Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)

Steps to reproduce the behavior:

  1. In the sample app, select a tab (e.g. Control, Animations, Services).
  2. Click on the "i" button on the lower right corner of an item.
  3. App crashes.

Expected behavior

App not crashes and show a flyout of a brief description of the corresponding item.

Screenshots

image

The button at the lower right corner

Environment

NuGet Package(s): 7.0

Package Version(s): 7.0

Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] May 2020 Update (19041)
- [x] Insider Build (build number: 21322)

App min and target version:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] May 2020 Update (19041)
- [ ] Insider Build (xxxxx)

Device form factor:
- [x] Desktop
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [ ] 2017 (version: )
- [ ] 2019 (version: ) 
- [ ] 2019 Preview (version: )

Additional context

Add any other context about the problem here.
@huynhsontung huynhsontung added the bug 🐛 An unexpected issue that highlights incorrect behavior label Mar 12, 2021
@ghost ghost added the needs triage 🔍 label Mar 12, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

Hello huynhsontung, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@Kyaa-dost
Copy link
Contributor

@huynhsontung Thanks for the catch!! Do you want to work on this and create a PR?

@FireCubeStudios
Copy link

same issue here

@huynhsontung
Copy link
Contributor Author

@Kyaa-dost Sure. I think I figured out the problem. I will create a PR shortly.

@huynhsontung huynhsontung mentioned this issue Mar 12, 2021
Merged
8 tasks
@ghost ghost added the In-PR 🚀 label Mar 12, 2021
@michael-hawker michael-hawker added this to the 7.0.1 milestone Mar 13, 2021
@ghost ghost closed this as completed in #3837 Mar 15, 2021
ghost pushed a commit that referenced this issue Mar 15, 2021
Fix wrong bracket matching when parsing Vectors (#3837)
0ff1745 
<!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 -->

<!-- 📝 It is preferred if you keep the "☑️ Allow edits by maintainers" checked in the Pull Request Template as it increases collaboration with the Toolkit maintainers by permitting commits to your PR branch (only) created from your fork.  This can let us quickly make fixes for minor typos or forgotten StyleCop issues during review without needing to wait on you doing extra work. Let us help you help us! 🎉 -->


## Fixes #3834
<!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. -->

<!-- Add a brief overview here of the feature/bug & fix. -->
Fixed wrong bracket matching in `StringExtensions.ToVectorN(string)` and `StringExtensions.ToQuaternion(string)` methods.

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

- Bugfix
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## What is the current behavior?
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
Sample app crashes.


## What is the new behavior?
<!-- Describe how was this issue resolved or changed? -->
Sample app does not crash.


## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
- [ ] Sample in sample app has been added / updated (for bug fixes / features)
    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [ ] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/windows-toolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [ ] Contains **NO** breaking changes

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. 
     Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. -->


## Other information
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Mar 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 14, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 sample app 🖼 sample bug 🐛
Projects
None yet
Milestone
7.0.1
Development

Successfully merging a pull request may close this issue.

Fix wrong bracket matching when parsing Vectors huynhsontung/WindowsCommunityToolkit
4 participants
@michael-hawker @huynhsontung @Kyaa-dost @FireCubeStudios