-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong bracket matching when parsing Vectors #3837
Conversation
Thanks huynhsontung for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @huynhsontung! Looks good to me 🚀 🚀
@Sergio0694 I think you updated this last, you want to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me once the small comment is addressed! 🚀
Thanks for spotting that typo!
Hello @Sergio0694! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Looks good, thanks for making those changes @huynhsontung! |
@Sergio0694 mind opening an issue for 7.1 about having Unit Tests for these converters/helper methods? |
Fixes #3834
Fixed wrong bracket matching in
StringExtensions.ToVectorN(string)
andStringExtensions.ToQuaternion(string)
methods.PR Type
What kind of change does this PR introduce?
What is the current behavior?
Sample app crashes.
What is the new behavior?
Sample app does not crash.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information