Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong bracket matching when parsing Vectors #3837

Merged
4 commits merged into from
Mar 15, 2021

Conversation

huynhsontung
Copy link
Contributor

@huynhsontung huynhsontung commented Mar 12, 2021

Fixes #3834

Fixed wrong bracket matching in StringExtensions.ToVectorN(string) and StringExtensions.ToQuaternion(string) methods.

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Sample app crashes.

What is the new behavior?

Sample app does not crash.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Mar 12, 2021

Thanks huynhsontung for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi, Kyaa-dost and Rosuavio March 12, 2021 22:03
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior sample app 🖼 sample bug 🐛 labels Mar 12, 2021
Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @huynhsontung! Looks good to me 🚀 🚀

@michael-hawker
Copy link
Member

@Sergio0694 I think you updated this last, you want to review?

@michael-hawker michael-hawker added this to the 7.0.1 milestone Mar 13, 2021
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once the small comment is addressed! 🚀
Thanks for spotting that typo!

@ghost
Copy link

ghost commented Mar 15, 2021

Hello @Sergio0694!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@Sergio0694
Copy link
Member

Looks good, thanks for making those changes @huynhsontung!
Added the auto-merge tag, should go in as soon as the CI tests pass 😄🎉

@ghost ghost merged commit 0ff1745 into CommunityToolkit:master Mar 15, 2021
@michael-hawker
Copy link
Member

@Sergio0694 mind opening an issue for 7.1 about having Unit Tests for these converters/helper methods?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior extensions ⚡ sample app 🖼 sample bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking the information button in the sample app crashes the app
4 participants