Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for Vector2/3/4/Quaternion parsing #3854

Merged

Conversation

Sergio0694
Copy link
Member

Follow up for #3743 and #3837

PR Type

What kind of change does this PR introduce?

  • Unit tests

What is the current behavior?

There are no unit tests for ToVector2/3/4 and ToQuaternion extensions.

What is the new behavior?

Added unit tests for all those extensions.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented Mar 17, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi, Kyaa-dost and Rosuavio March 17, 2021 14:38
@Kyaa-dost Kyaa-dost added this to the 7.0.1 milestone Mar 17, 2021
@michael-hawker
Copy link
Member

Thanks @Sergio0694!

@michael-hawker michael-hawker merged commit 5462c5e into CommunityToolkit:master Mar 17, 2021
@Sergio0694 Sergio0694 deleted the tests/vector-parse-brackets branch March 17, 2021 22:42
@Sergio0694 Sergio0694 restored the tests/vector-parse-brackets branch March 18, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants