Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faillure rendering sample docs. #4116

Closed
1 of 2 tasks
Rosuavio opened this issue Jul 19, 2021 · 0 comments · Fixed by #4095
Closed
1 of 2 tasks

Faillure rendering sample docs. #4116

Rosuavio opened this issue Jul 19, 2021 · 0 comments · Fixed by #4095
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 markdown 📑 Issues related to Markdown sample app 🖼
Milestone

Comments

@Rosuavio
Copy link
Contributor

Describe the bug

A clear and concise description of what the bug is.
Some doc pages fail to render in the sample app due to not being able to handle certain markdown.
When parsing special quotes with special style tags like [!NOTE] or [!TIP], the sample app does not handle there not being one of those style tags at the beginning of the quote and the example code would crash the rendered.

In the SampleApp there are docs that we render that have the markdown syntax

> Hello world

And should be rendered as

Hello world

But instead the doc fails to render and none of the doc page is shown.

  • Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:

Steps to Reproduce

  • Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)

Steps to reproduce the behavior:

  1. Open SampleApp
  2. Open login button sample
  3. See no docs.

Expected behavior

A clear and concise description of what you expected to happen.
Login button docs and other docs with the md syntax > work.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

NuGet Package(s):

Package Version(s):

Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] May 2020 Update (19041)
- [ ] Insider Build (build number: )

App min and target version:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] May 2020 Update (19041)
- [ ] Insider Build (xxxxx)

Device form factor:
- [ ] Desktop
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio
- [ ] 2017 (version: )
- [ ] 2019 (version: )
- [ ] 2019 Preview (version: )

Additional context

Add any other context about the problem here.

@Rosuavio Rosuavio added the bug 🐛 An unexpected issue that highlights incorrect behavior label Jul 19, 2021
@michael-hawker michael-hawker added this to the 7.1 milestone Jul 19, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Jul 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 markdown 📑 Issues related to Markdown sample app 🖼
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants