Check style.Ignore if style is not null. #4095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4116
Style could have been null on the check for style.Ignore, moved the
check so it cant be null.
In the SampleApp there are docs that we render that have the markdown syntax
> Hello world
And should be rendered as
The issues is our code that checks for special quotes with special style tags like
[!NOTE]
or[!TIP]
does not handle there not being one of those style tags at the beginning of the quote and the example code would crash the rendered. This change no longer checksstyle.Ignore
if the style tag is not in our dictionary.PR Type
What kind of change does this PR introduce?
What is the current behavior?
Markdown quotes that don't start with a style tag cash the sample app.
What is the new behavior?
Markdown quotes that don't start with a style tag don't get checked if there non-existing style's Ignore prop is true.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
How it looks now
Source https://github.com/MicrosoftDocs/WindowsCommunityToolkitDocs/blob/a70069e9d133b677507e37f526eadc08299202b5/docs/graph/controls/PersonView.md