Add ThirdPartyNotice file to packages #4158
Labels
bug 🐛
An unexpected issue that highlights incorrect behavior
build 🔥
Completed 🔥
documentation 📃
good first issue
Issues identified as good for first-time contributors
Milestone
Comments
michael-hawker
added
bug 🐛
|
Also noticed we're missing the last two copies of licenses in the file... 🙋♂️ |
michael-hawker
added
the
good first issue
|
We also have a |
|
The Third Party Notice file is a legal document we just need to include. It's not something we need to put content into the readme for. |
|
That's not what I meant. |
michael-hawker
added a commit
to michael-hawker/UWPCommunityToolkit
that referenced
this issue
Sep 15, 2021
ghost
pushed a commit
that referenced
this issue
Sep 16, 2021
## Fixes #4210 and Fixes #4158 Cleans up sample for #4248 (though underlying issue remains to be figured out later). Fixes a sample and cleans-up a few items we missed in our nuget packages. Just need to validate output from CI, but should be fairly straight-forward. ## PR Type What kind of change does this PR introduce? <!-- Please uncomment one or more options below that apply to this PR. --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> - Documentation content changes - Sample app changes <!-- - Other... Please describe: --> ## What is the current behavior? TTB Sample was binding to the internal collection instead of showing binding to a developer provided collection. Some new features were missing from the NuGet package info. ## What is the new behavior? Fixed! 🎉 ## PR Checklist Please check if your PR fulfills the following requirements: <!-- and remove the ones that are not applicable to the current PR --> - [ ] Tested code with current [supported SDKs](../#supported) - [ ] New component - [ ] Pull Request has been submitted to the documentation repository [instructions](../blob/main/Contributing.md#docs). Link: <!-- docs PR link --> - [ ] Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that) - [ ] If control, added to Visual Studio Design project - [ ] Sample in sample app has been added / updated (for bug fixes / features) - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/CommunityToolkit/WindowsCommunityToolkit-design-assets) - [ ] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/CommunityToolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc... - [ ] Tests for the changes have been added (for bug fixes / features) (if applicable) - [ ] Header has been added to all new source files (run _build/UpdateHeaders.bat_) - [ ] Contains **NO** breaking changes <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. --> ## Other information <!-- Please add any other information that might be helpful to reviewers. -->
ghost
locked as resolved and limited conversation to collaborators
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
We should add our ThirdPartyNotice.txt file to our packages as a loose file like we do with the license.
Should be here:
WindowsCommunityToolkit/build/Windows.Toolkit.Common.targets
Lines 15 to 18 in 41b0c9a
The text was updated successfully, but these errors were encountered: