-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New 7.1 Controls missing from package descriptions #4210
Comments
This might not be the best way moving forward. We should instead add a |
Not sure if we want to have a readme for every package, this is mostly for folks to easily see a quick list of things in the package when finding the package on NuGet or in Visual Studio. |
We'll still have a brief list but a little bit verbosity won't hurt anyone. Infact, it could give users an intro into the Toolkit. |
## Fixes #4210 and Fixes #4158 Cleans up sample for #4248 (though underlying issue remains to be figured out later). Fixes a sample and cleans-up a few items we missed in our nuget packages. Just need to validate output from CI, but should be fairly straight-forward. ## PR Type What kind of change does this PR introduce? <!-- Please uncomment one or more options below that apply to this PR. --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> - Documentation content changes - Sample app changes <!-- - Other... Please describe: --> ## What is the current behavior? TTB Sample was binding to the internal collection instead of showing binding to a developer provided collection. Some new features were missing from the NuGet package info. ## What is the new behavior? Fixed! 🎉 ## PR Checklist Please check if your PR fulfills the following requirements: <!-- and remove the ones that are not applicable to the current PR --> - [ ] Tested code with current [supported SDKs](../#supported) - [ ] New component - [ ] Pull Request has been submitted to the documentation repository [instructions](../blob/main/Contributing.md#docs). Link: <!-- docs PR link --> - [ ] Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that) - [ ] If control, added to Visual Studio Design project - [ ] Sample in sample app has been added / updated (for bug fixes / features) - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/CommunityToolkit/WindowsCommunityToolkit-design-assets) - [ ] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/CommunityToolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc... - [ ] Tests for the changes have been added (for bug fixes / features) (if applicable) - [ ] Header has been added to all new source files (run _build/UpdateHeaders.bat_) - [ ] Contains **NO** breaking changes <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. --> ## Other information <!-- Please add any other information that might be helpful to reviewers. -->
Thx |
Describe the bug
Looks like in the NuGet package description we're missing the new controls we've added in 7.1: ContrainedBox, MetadataControl, RichSuggestBox.
Probably some of the behaviors from the behavior package.
We should add them to the package description (without going over 4000 char limit).
Steps to Reproduce
Steps to reproduce the behavior:
Expected behavior
Controls listed in description
Environment
NuGet Package(s): 7.1.0-rc1
Package Version(s):
Windows 10 Build Number:
App min and target version:
Device form factor:
Visual Studio version:
Additional context
The text was updated successfully, but these errors were encountered: