-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nuget package badge and link #384
Add nuget package badge and link #384
Conversation
A table format should be a better choice instead of in-lining the badges. They also look mis-aligned! |
This looks nice but add the help links to the package name column and add a description column at the end. Like this.
|
@Nirmal4G updated with table, looks better, thanks |
Co-authored-by: Nirmal Guru <Nirmal4G@gmail.com>
If we do that, then we should display both @Sergio0694 and @michael-hawker Thoughts? |
Not sure what you mean, we've already migrated away. I literally deprecated the |
I should have mentioned that "we" is "Community"! Sorry about that. But if it's not needed to display older packages, then we can remove it! Just wanted to be sure!! 😇 |
PR #439 should merge first. It might break this. So, don't forget to use the updated URLs and rebase on top of that merge. |
So we need the source generator package listed given it's not a package? |
No, it should not be listed, it was my mistake adding that initially. It's just not a package, it should not be there 🙂 |
…egisterAllGenerator to provide a nicer "unsupported C# language version" diagnostic instead of simply generating unsupported code and failing later in compilation
…t, update tests to use the minimum supported C# language version (8.0), and also validate that unsupported version cases actually succeed with the supported version
These two generators should never cause a build error
Close it for a clean commit PR |
You could've just force-pushed!? Anyways it's fine. |
**Closes #148 **
Preview here: https://github.com/WeihanLi/dotnet-CommunityTookit/blob/nuget-package-enhancement/README.md
Add the NuGet package badge and link to the NuGet package, hope it would help developers find the NuGet packages more easily
PR Checklist
Other information