Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLs for Status Badges in Readme #439

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Update URLs for Status Badges in Readme #439

merged 1 commit into from
Sep 15, 2022

Conversation

michael-hawker
Copy link
Member

Fixes #422

Updates status badge urls to point to the proper pipeline status and definitions for links.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

Main question left is about linking to the NuGet org profile vs. specific search or something (though I don't think we have a specific way to pull out only .NCT packages).

@michael-hawker michael-hawker added the documentation 📃 Some proposed change related to documentation label Sep 13, 2022
@Nirmal4G Nirmal4G mentioned this pull request Sep 15, 2022
12 tasks
@Sergio0694 Sergio0694 merged commit f73ff85 into main Sep 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the readme-updates branch September 15, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📃 Some proposed change related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuGet link in README points to confusing results
2 participants