Skip to content

Commit

Permalink
T1627 - Fix BeneficiaryMajorRevision GMC request handling (#1941)
Browse files Browse the repository at this point in the history
* found bug, need to see how to fix it

* fixed 'Local Grade Level' is empty in revision, fixed revision applies all revisions to same type on single child, need to see how to handle update/create

* probably fixed major revision not cleared/updated correctly

* cleanup

* removed data_filter in _json_to_relational_field since it wasn't used. Changed ma mapping of RevisedValues

* reverted all changes in field_to_json

---------

Co-authored-by: Clément <100228798+clementcharmillot@users.noreply.github.com>
  • Loading branch information
Prazn and clementcharmillot authored Aug 15, 2024
1 parent e7c901a commit 885506e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions child_compassion/models/major_revision.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ def get_child_field_mapping(self):
"Last Name": "lastname",
"Planned Completion Date": "completion_date",
"Preferred Name": "preferred_name",
"Local Grade Level": "local_grade_level",
}

def get_field_value(self):
Expand Down
2 changes: 1 addition & 1 deletion child_compassion/static/mappings/child.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"PreferredName": "preferred_name",
"RevisedValues": {
"field": "revised_value_ids.name",
"search_relational_record": true
"search_relational_record": false
},
"SponsorshipStatus": "sponsorship_status",
"SponsoredStatus": "sponsorship_status",
Expand Down

0 comments on commit 885506e

Please sign in to comment.