T1627 - Fix BeneficiaryMajorRevision GMC request handling #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prazn
force-pushed
the
nip/T1627-FixMajorRevision
branch
from
cda14ef
to
2748a4e
Compare
…s all revisions to same type on single child, need to see how to handle update/create
Prazn
force-pushed
the
nip/T1627-FixMajorRevision
branch
from
a9edd18
to
1dde539
Compare
…. Changed ma mapping of RevisedValues
|
ecino
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug related to notifying a sponsor when information about his child changed. The sponsor would in fact be notified through the
BeneficiaryMajorRevisionGMC message, however the contents of the letter would be weird, for example 14'000 lines of repeating text.Technical Aspects
The first fix of this PR is that there was no mapping made for the 'Local Grade Level' to get the corresponding field from the json. This is why in the letter the grade was empty.
The second fix is a bit more complex and related to how we map the json to ORM methods, basically the
RevisedValuesfield was mapped as having relation records through a foreign key, but it wasn't the case. So when the mapping was done we would have incorrect ORM methods which corrupted the data inside the table as time went on.Misc
The existing data in the table
compassion_major_revisionshould be cleared since the data is wrong.