tooling(delete-rem-tags): pass git commit info #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liketechnik
force-pushed
the
fix/delete-rem-tags-commit-info
branch
from
61e8ba6 to
f576c36
Compare
|
Ich habe den PR jetzt bei mir lokal getestet. Wenn nicht noch weitere Unterschiede zwischen verschiedensten Git und/oder Docker-Konfigurationen für Probleme sorgen, die ich nicht auf dem Schirm habe, funktioniert das in der Form. |
|
Bei mir sieht die Ausgabe leider immer noch so aus: |
Passes git author information via environment variables into the docker container, in order to ensure commits done by the script have correct author information.
Pass not only author information, but committer information too, since git seems to be *sometimes* unhappy with only author information, for whatever reason.
liketechnik
force-pushed
the
fix/delete-rem-tags-commit-info
branch
from
f576c36 to
4479be3
Compare
|
Hmm. Spannend, bei mir im Container hatte ich das Problem nicht, da war Git dann schon mit ausschließlich mit @malt-r Kannst du das nochmal bei dir testen? Tut mir leid dass ich damit jetzt zum x-ten Mal komme... |
|
Jetzt klappt's! :) |
malt-r
approved these changes
Jul 18, 2022
|
@liketechnik d.h. ich kann jetzt mergen? wie war das, zuerst muss #16, richtig? |
neee, scheinbar erst der hier (#19), und danach dann #16. so richtig? |
cagix
added a commit
that referenced
this pull request
Jul 18, 2022
* tooling: git safe repo directory for docker image Fixes an issue introduced with a recent git update (https://github.blog/2022-04-12-git-security-vulnerability-announced/) with a common workaround (actions/checkout#762, https://stackoverflow.com/questions/71901632/fatal-error-unsafe-repository-home-repon-is-owned-by-someone-else, actions/checkout#760), by marking the /data directory inside the container as safe for git during the container build. * tooling: point git to directory instead of disabling security features Easier to maintain version of 7c2b552 that additionally does not fiddle with security sensitive settings. * style(Makefile): docker git env into separate variable * tooling: extract repo location inside container into variable * tooling: replace missing hardcoded /data with variable Co-authored-by: Carsten Gips <cagix@fh-bielefeld.de> * tooling(delete-rem-tags): pass git commit info (#19) * tooling(delete-rem-tags): pass git commit info Passes git author information via environment variables into the docker container, in order to ensure commits done by the script have correct author information. * tooling(delete-rem-tags): pass git full commit info Pass not only author information, but committer information too, since git seems to be *sometimes* unhappy with only author information, for whatever reason. * tooling: makefile formatting Co-authored-by: Carsten Gips <cagix@fh-bielefeld.de> * tooling: makefile formatting Co-authored-by: Carsten Gips <cagix@fh-bielefeld.de> * tooling: makefile formatting Co-authored-by: Carsten Gips <cagix@fh-bielefeld.de> Co-authored-by: Carsten Gips <cagix@fh-bielefeld.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes git author information via environment variables into the docker
container, in order to ensure commits done by the script have correct
author information.
Since the changes in the Makefile occur in the same position as in #16 this PR is based on the changes in #16 and currently targets the branch of #16. GitHub should automatically adjust the target branch if #16 gets merged first (although I just heard it does, I've not tried it yet).
Fixes #18