CMP-2524: Only load node profiles for managed OpenShift #518
Conversation
|
@rhmdnd: This pull request references CMP-2524 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
rhmdnd
requested review from
yuumasato and
xiaojiey
and removed request for
mrogers950
|
This still has a rough edge with the kustomization work and detecting platform deployments. Need to find an orthogonal way to handle spinning up tests on platforms. |
|
The ROSA test worked... but still need to do some cleanup |
Made change to be able to detect what managed cluster we are on using ClusterClaim and added ROSA platform type. This makes it easier for users to run the operator on ROSA, without having to specify the platform. Additional patches can use this to by smarter about loading in specific resources on ROSA, like profiles and scan configs.
rhmdnd
force-pushed
the
CMP-2524-rosa-profile-support
branch
from
57834fa
to
ef4c809
Compare
bundle/manifests/compliance-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
Implement support for only loading node profiles on managed offerings since the control plane isn't accessible. This reduces the amount of confusion for users by only presenting profiles that can be run on the platform.
rhmdnd
force-pushed
the
CMP-2524-rosa-profile-support
branch
from
ef4c809
to
2c7d5f5
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f3ce7cc
into
ComplianceAsCode:master
We're seeing a panic in the log when parsing profiles on managed offerings: "msg":"odd number of arguments passed as key-value pairs for logging","ignored key" This is likely related to ComplianceAsCode#518 This commit updates the log to use a key-value pair so that the panic goes away.
Implement support for only loading node profiles on managed offerings
since the control plane isn't accessible. This reduces the amount of
confusion for users by only presenting profiles that can be run on the
platform.