CMP-2526: Disable automatic remediation for ROSA HCP environments #520
Conversation
|
@Vincent056: This pull request references CMP-2526 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tests/e2e/rosa/main_test.go
Outdated
| if err != nil { | ||
| t.Fatalf("Failed to list cluster claims: %v", err) | ||
| } | ||
| for _, clusterClaim := range clusterClaimList.Items { |
There was a problem hiding this comment.
I probably could have pulled this into it's own test in #518.
We can clean this up after though.
Since the Compliance Operator is only going to support running on HCP environments, where end users don't have access to the master nodes (or control plane), it doesn't make sense to give them a scan setting with auto remediation functionality applied. For this case, the Compliance Operator should detect if it is running on ROSA HCP and adjust, or just not create the `default-auto-apply` scan settings.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 2a63fdf
into
ComplianceAsCode:master
Since the Compliance Operator is only going to support running on HCP environments, where end users don't have access to the master nodes (or control plane), it doesn't make sense to give them a scan setting with auto remediation functionality applied.
For this case, the Compliance Operator should detect if it is running on ROSA HCP and adjust, or just not create the
default-auto-applyscan settings.