fix: limit action name chars

[angrybayblade]

🔍 Review Summary

Release Note

Purpose:

• Enhance the Composio toolset by introducing a character limit feature for action names.

Changes:

• New Feature: Added a character limit for action names to prevent exceeding specified lengths.
• Enhancement: Optimized initialization to support the new character limit feature.
• Test: Updated test suite to verify correct initialization and enforcement of character limits.
• Style: Improved test file path formatting for better readability.

Impact:

• Streamlines user interactions, ensuring action names are concise, enhancing readability, reliability, and ease of use.

Original Description

This PR updates base toolset to allow limiting number of characters for action name in a schema

fixes: ENG-2917

---

[!IMPORTANT]
Adds character limit for action names in ComposioToolSet, with default set in Langchain integration and tests added.

• Behavior:
  • Adds _action_name_char_limit to ComposioToolSet in toolset.py to limit action name length.
  • Truncates action names in _process_schema() if limit is set.
• Langchain Integration:
  • Sets default action_name_char_limit to 64 in composio_langchain/toolset.py.
• Tests:
  • Adds test_action_name_char_limit() in test_toolset.py to verify action name truncation.
  • Updates TestSubclassInit to include action name limit tests.

^{This description was created by for 3eb8a68. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
composio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 23, 2024 7:20am

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 3eb8a68 in 15 seconds

More details

• Looked at 142 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. python/composio/tools/toolset.py:990

• Draft comment:
  Ensure _action_name_char_limit is non-negative before slicing to avoid unexpected behavior.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR introduces a new feature to limit the number of characters for action names. This is implemented in the _process_schema method of the ComposioToolSet class. The feature is tested in the TestSubclassInit class, specifically in the test_action_name_char_limit method. The implementation seems correct, but there is a potential issue with the slicing operation that could lead to unexpected behavior if the limit is set to a negative number. It's important to ensure that the limit is non-negative before applying it.

Workflow ID: wflow_SmYyLKInliQA0Eou

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[entelligence-ai-pr-reviews]

Walkthrough

This update introduces a character limit feature for action names in the Composio toolset, enhancing the existing description character limit functionality. Modifications were made to the toolset initialization to support this new limit, ensuring action names do not exceed specified lengths. A new test suite was added to verify the correct initialization of subclasses and the enforcement of character limits for both descriptions and action names.

Changes

File(s)	Summary
python/composio/tools/toolset.py	Added support for action name character limit in the ComposioToolSet class, including modifications to the initialization process to handle this new parameter.
python/plugins/langchain/composio_langchain/toolset.py	Implemented a 64-character limit for action names in the Langchain Composio toolset.
python/tests/test_tools/test_toolset.py	Added tests to verify the initialization of subclasses and the enforcement of character limits for descriptions and action names.
python/tests/test_example.py	Adjusted test file path formatting for better readability.

🔗 Related PRs

• chore: unpin pydantic #967: The pull request unpins the pydantic version in setup.py for compatibility with newer versions and updates type annotations across multiple files to reflect this change.
• fix: model serialization should be to dict, not json #1033: The update improves the serialization in toolset.py from JSON to dictionary format, enhancing data manipulation and reliability, along with new test cases for validation.
• ci: Add action to lint PR titles #956: The pull request introduces a GitHub Action to validate PR titles against conventional commit formats using amannn/action-semantic-pull-request, enhancing CI/CD workflows.
• fix: bring eslint + TS issues to zero #1013: The pull request aims to enhance code quality and type safety by enforcing stricter ESLint rules, refactoring code, and improving error handling, resulting in a more maintainable and robust codebase.

Instructions

Emoji Descriptions:

• ⚠️ Potential Issue - May require further investigation.
• 🔒 Security Vulnerability - Fix to ensure system safety.
• 💻 Code Improvement - Suggestions to enhance code quality.
• 🔨 Refactor Suggestion - Recommendations for restructuring code.
• ℹ️ Others - General comments and information.

Interact with the Bot:

• Send a message or request using the format:
  @bot + *your message*

Example: @bot Can you suggest improvements for this code?

• Help the Bot learn by providing feedback on its responses.
  @bot + *feedback*

Example: @bot Do not comment on `save_auth` function !

Execute a command using the format:

@bot + */command*

Example: @bot /updateCommit

Available Commands:

• /updateCommit ✨: Apply the suggested changes and commit them (or Click on the Github Action button to apply the changes !)
• /updateGuideline 🛠️: Modify an existing guideline.
• /addGuideline ➕: Introduce a new guideline.

Tips for Using @bot Effectively:

• Specific Queries: For the best results, be specific with your requests.
  🔍 Example: @bot summarize the changes in this PR.
• Focused Discussions: Tag @bot directly on specific code lines or files for detailed feedback.
  📑 Example: @bot review this line of code.
• Managing Reviews: Use review comments for targeted discussions on code snippets, and PR comments for broader queries about the entire PR.
  💬 Example: @bot comment on the entire PR.

Need More Help?

📚 Visit our documentation for detailed guides on using Entelligence.AI.
🌐 Join our community to connect with others, request features, and share feedback.
🔔 Follow us for updates on new features and improvements.

[shreysingla11]

Code Review Summary

The PR implements action name character limits in a clean and maintainable way. The implementation is solid with good test coverage.

Strengths:

✅ Clean implementation following existing patterns
✅ Proper type hints and documentation
✅ Maintains backward compatibility
✅ Good test coverage for main functionality
✅ Configurable per toolset implementation

Suggestions for Improvement:

1. Add docstring for the new _action_name_char_limit class variable
2. Add warning message when action_name_char_limit is not set (for consistency)
3. Add test cases for edge cases (0, 1, negative values, very large values)

Overall Assessment:

The code is well-structured and implements the feature correctly. The changes are focused and maintain backward compatibility. After addressing the minor suggestions above, this PR would be ready to merge.

Code Quality Rating: 8/10 (Very Good)

• Clean implementation: ⭐⭐⭐
• Test coverage: ⭐⭐
• Documentation: ⭐⭐
• Maintainability: ⭐