-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add action to lint PR titles #956
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 09a50ed in 35 seconds
More details
- Looked at
27
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_pXvw8oxdnHcswjV4
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
name: Validate PR title | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: amannn/action-semantic-pull-request@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a configuration for the action-semantic-pull-request
to specify the expected PR title format. This ensures the action checks against the desired title conventions.
name: Validate PR title | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: amannn/action-semantic-pull-request@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding configuration options for the semantic PR action to match the project's existing commit message standards. For example:
- uses: amannn/action-semantic-pull-request@v5
with:
# Define allowed types based on your development.md guidelines
types: |
feat
fix
docs
test
# Add a helpful error message
errorComment: |
Please follow the semantic PR title format as defined in python/docs/development.md
Review SummaryCode Quality: 8/10Positive Aspects:
Suggestions for Improvement:
The implementation is solid and will help enforce the project's existing semantic commit standards. The suggestions are mainly about improving user experience rather than fixing technical issues. |
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
PR titles must follow conventional commits:
etc.
Important
Adds GitHub Action to validate pull request titles for semantic format using
amannn/action-semantic-pull-request
..github/workflows/pr_title.yml
to check PR titles for semantic format.opened
,edited
,synchronize
, andreopened
pull request events.amannn/action-semantic-pull-request@v5
to validate titles.pull-requests: read
permission.This description was created by
for 09a50ed. It will automatically update as commits are pushed.