fix plugin energy field reduce #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrometheusPi
requested review from
ax3l,
psychocoderHPC,
BeyondEspresso and
steindev
|
All in all this is a out of memory access within the stack and could have unknown side effects. |
psychocoderHPC
added
the
affects latest release
psychocoderHPC
requested changes
Jun 30, 2017
| @@ -219,7 +219,7 @@ class EnergyFields : public ISimulationPlugin | |||
| mpiReduce(nvidia::functors::Add(), | |||
| &globalFieldEnergy, | |||
| &localReducedFieldEnergy, | |||
| 2, | |||
| 1, /* only 1 reduce because type is float3_x[2] */ | |||
There was a problem hiding this comment.
after thinking about the fix I think we should fix it the other way around, this would be more intuitive
globalFieldEnergy,
localReducedFieldEnergy,
2,
mpi::reduceMethods::Reduce());
PrometheusPi
force-pushed
the
fix_pluginEnergyField
branch
from
17a3d38 to
aee7784
Compare
|
I tested this with the TWTS/plane wave setup and got the same result for both 1 GPU and 2 GPUs. |
psychocoderHPC
approved these changes
Jul 3, 2017
2 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a wrong MPI reduce in the field energy plugin.
It caused wrong field values (f.e. in TWTS runs) because the mpi reduce reduces over two
float3_X[2]instead of over just onefloat3_X[2](which is equal two 2float3_X- which was probably the intention of the developer).Thanks @psychocoderHPC for spotting this!
Run time test show taht this solves the wrong output we see during TWTS runs.
(This effects all heating tests)
Effects so far:
So far this caused mostly some massively increased
Ezvalues.This does not effect the physics - just the output.
Test
CC-ing: @steindev, @BeyondEspresso