Esirkepov: reorder code order #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use the EmZ Esirkepov implementation as base to reorder the Esirkepov code - use helper variables to avoid multiple calculations of the some value - add `S1()` helper method
psychocoderHPC
added
component: core
TSC X-direction flowheating 3D
charge conservation
|
PCS Z-direction flowheating 3D
charge conservation
|
|
memo to ourselves: the KHI test could cover more aspects if we set up non-cubic cells. |
Would it be in this case also useful to propagate the particles over the diagonals? |
|
yes, as long as they are a lot of sub-relativistic particles as in this test case and enough turbulence, enough will leave and enter cells in any way possible. |
ax3l
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds intermediate results to the core routines to reduce the computation. The optimizations are copied from the EmZ Esirkepov solver. Currently it is not possible to use a shared version of the Esirkepov core deposition algorithm to both solvers to reduce the code duplication's.
S1()helper methodThis pull request increase the speed of PIConGPU in the KHI example with positron/ electrons 3D by a factor of 1.05.
Tests
I cherry picked this PR for the tests to the branch for the emz paper ( picongpu_0.3.0+#2112), because there I have already all results to validate the solver changes.