fix plotting tool for numerical heating #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field energy is ignored/not used in the tool `plotNumericalHeating`. This results into a wrong heating plot. - add usage of `fields_energy.dat` - fix documentation
psychocoderHPC
added
component: tools
PrometheusPi
approved these changes
Sep 3, 2018
ax3l
reviewed
Sep 4, 2018
| @@ -119,7 +119,7 @@ for sim in directories: | |||
| mydir = sim+simDir | |||
| # get relevant files with energy | |||
| files = [f for f in os.listdir(mydir) | |||
| if os.path.isfile(os.path.join(mydir, f)) and re.search('^.*_energy_all.dat', f)] | |||
| if os.path.isfile(os.path.join(mydir, f)) and (re.search('^.*_energy_all.dat', f) or re.search('^.fields_energy.dat', f))] | |||
| # check if file list is empty | |||
| if len(files) == 0: | |||
| sys.exit("There were no energy files in \"{}\".".format(mydir)) | |||
There was a problem hiding this comment.
I wonder if we should also at least print a warning of the field energy is missing.
There was a problem hiding this comment.
But in the case where I will only plot the lose of energy of an moving particle species (maybe one particle) it is not needed.
A suggestion is to rename this to something like plotGlobalHeating and enforce at least one particle species and the field energy.
There was a problem hiding this comment.
Yep, we should just restructure this tool as we do with other plugin post-processing scripts into lib/python/picongpu/: a module for data loading and two plot interfaces, one for actual "simulation heating" and another for simple plots of contained energy in specific species, fields, etc.
ax3l
approved these changes
Sep 4, 2018
Closed
psychocoderHPC
added a commit
to psychocoderHPC/picongpu
that referenced
this pull request
Aug 10, 2020
The tool should be fixed with ComputationalRadiationPhysics#2697 but because of wrong regex the tool is still broken.
psychocoderHPC
added a commit
to psychocoderHPC/picongpu
that referenced
this pull request
Aug 10, 2020
The tool should be fixed with ComputationalRadiationPhysics#2697 but because of wrong regex the tool is still broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2687
The field energy is ignored/not used in the tool
plotNumericalHeating.This results into a wrong heating plot.
fields_energy.dat