Release 0.4.0-rc3 #2699
Merged
Release 0.4.0-rc3 #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field energy is ignored/not used in the tool `plotNumericalHeating`. This results into a wrong heating plot. - add usage of `fields_energy.dat` - fix documentation
ax3l
added
bug
The game of life example has a runtime issue that the mapping description verification to check the number of supercells is always twrowing an error. The reason it that the not existing default constructor is `MappingDescription` is used. - create the object for mapping description inside the init method of `Evolution` - `MappingDescription` remove the default for the parameter `localGridCells`
Allow the PIConGPU user to select the alpaka accelerator `ALPAKA_ACC_CPU_B_SEQ_T_THREADS_ENABLE`. This accelerator is called in PIConGPU `threads`. - add `threads` to the `-b` option of `pic-configure` - update help of `pic-configure`
Deprecation warning in Boost 1.67+
```
include/boost/math/common_factor_rt.hpp:13:93:
note: #pragma message: This header is deprecated.
Use <boost/integer/common_factor_rt.hpp> instead.
BOOST_HEADER_DEPRECATED("<boost/integer/common_factor_rt.hpp>");
```
https://github.com/boostorg/math/blob/boost-1.67.0/include/boost/math/common_factor_rt.hpp
The workaround disabling template aliases causes compile errors on Titan (ORNL), both when compiling with CPU backend or CUDA 9.1.85. Applies the following logic changes: - only enable when compiling with NVCC for CUDA backend - only enable when NVCC < 9.1 - NVCC 8.0 known to be broken - NVCC 9.0 unknown, maybe fixed this already: https://svn.boost.org/trac10/ticket/11897#comment:22
If the path to `egetopt` is not in the environment variable `PATH` tbg falls back to use the `egetopt` in the same location as `tbg` itself. In that case the command `which` is throwing a long error message that egetopt can not be found. This PR hide the error message and create an own error message if needed.
Boost 1.68.0 is not allowed since ComputationalRadiationPhysics#2685 but after we will integrate the next alapak release we will end in compile issues. The reason is ComputationalRadiationPhysics#2707. The definition of `boost::math::gcd` is not available if `boost/integer/common_factor_rt.hpp` is included. This PR fixes the behaviour be using always `boost/integer/common_factor_rt.hpp` and use `boost::integer::gcd` within PMacc.
|
@psychocoderHPC let's merge this already, I will open a |
psychocoderHPC
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of all relevant PRs for the
release-0.4.0branch in the next days/weeks.Update to
0.4.0-rc3.Bug Fixes
Misc
0.4.0-rc3threadsacceleratorthreads#2701