Boost: Deprecated Math Header #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecation warning in Boost 1.67+
```
include/boost/math/common_factor_rt.hpp:13:93:
note: #pragma message: This header is deprecated.
Use <boost/integer/common_factor_rt.hpp> instead.
BOOST_HEADER_DEPRECATED("<boost/integer/common_factor_rt.hpp>");
```
https://github.com/boostorg/math/blob/boost-1.67.0/include/boost/math/common_factor_rt.hpp
ax3l
added
warning
psychocoderHPC
approved these changes
Sep 26, 2018
psychocoderHPC
added a commit
to psychocoderHPC/picongpu
that referenced
this pull request
Oct 4, 2018
Boost 1.68.0 is not allowed since ComputationalRadiationPhysics#2685 but after we will integrate the next alapak release we will end in compile issues. The reason is ComputationalRadiationPhysics#2707. The definition of `boost::math::gcd` is not available if `boost/integer/common_factor_rt.hpp` is included. This PR fixes the behaviour be using always `boost/integer/common_factor_rt.hpp` and use `boost::integer::gcd` within PMacc.
2 tasks
ax3l
pushed a commit
to ax3l/picongpu
that referenced
this pull request
Oct 5, 2018
Boost 1.68.0 is not allowed since ComputationalRadiationPhysics#2685 but after we will integrate the next alapak release we will end in compile issues. The reason is ComputationalRadiationPhysics#2707. The definition of `boost::math::gcd` is not available if `boost/integer/common_factor_rt.hpp` is included. This PR fixes the behaviour be using always `boost/integer/common_factor_rt.hpp` and use `boost::integer::gcd` within PMacc.
steindev
pushed a commit
to steindev/picongpu
that referenced
this pull request
Oct 16, 2018
Boost 1.68.0 is not allowed since ComputationalRadiationPhysics#2685 but after we will integrate the next alapak release we will end in compile issues. The reason is ComputationalRadiationPhysics#2707. The definition of `boost::math::gcd` is not available if `boost/integer/common_factor_rt.hpp` is included. This PR fixes the behaviour be using always `boost/integer/common_factor_rt.hpp` and use `boost::integer::gcd` within PMacc.
steindev
pushed a commit
to steindev/picongpu
that referenced
this pull request
Oct 16, 2018
Boost 1.68.0 is not allowed since ComputationalRadiationPhysics#2685 but after we will integrate the next alapak release we will end in compile issues. The reason is ComputationalRadiationPhysics#2707. The definition of `boost::math::gcd` is not available if `boost/integer/common_factor_rt.hpp` is included. This PR fixes the behaviour be using always `boost/integer/common_factor_rt.hpp` and use `boost::integer::gcd` within PMacc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation warning in Boost 1.67+
https://github.com/boostorg/math/blob/boost-1.67.0/include/boost/math/common_factor_rt.hpp