Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tbg error message #2712

Merged

Conversation

psychocoderHPC
Copy link
Member

If the path to egetopt is not in the environment variable PATH tbg falls back to use the egetopt in the same location as tbg itself. In that case the command which is throwing a long error message that egetopt can not be found.
This PR hide the error message and create an own error message if needed.

@psychocoderHPC psychocoderHPC added component: tools scripts, python libs and CMake warning code produces/produced a warning labels Oct 4, 2018
bin/tbg Outdated
@@ -275,7 +275,7 @@ help()
initCall="$0 $*"
projectPath="."

pathToegetopt=`which egetopt`
pathToegetopt="$(which egetopt 2>/dev/null)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the " quotes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it is allowed. But I will remove it.

@ax3l ax3l self-assigned this Oct 4, 2018
@ax3l ax3l self-requested a review October 4, 2018 09:37
If the path to `egetopt` is not in the environment variable `PATH` tbg falls back to use the `egetopt` in the same location as `tbg` itself. In that case the command `which` is throwing a long error message that egetopt can not be found.
This PR hide the error message and create an own error message if needed.
@ax3l ax3l merged commit 0c1d09e into ComputationalRadiationPhysics:dev Oct 5, 2018
@ax3l ax3l mentioned this pull request Oct 5, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tools scripts, python libs and CMake warning code produces/produced a warning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants