-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile wallet feature parity #29
base: main
Are you sure you want to change the base?
Conversation
c5c6b9d
to
9cbb13a
Compare
9cbb13a
to
ba43337
Compare
This reverts commit ba43337.
d0d5205
to
2bb8c8a
Compare
a89bdc1
to
b96eb05
Compare
5a1e92d
to
e0cd32f
Compare
527699a
to
1efcd67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/id_proofs.rs
Outdated
) | ||
.context("Could not produce proof.") | ||
.map_err(|e| e.to_call_failed(fn_name.to_string()))?; | ||
VersionedIdentityProof::try_from(concordium_base::common::Versioned::new(VERSION_0, proof)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand the purpose of this VERSION_0
. Will it always be 0 for now or is it related to the proofV2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the JS SDK, the proof produced for VERSION_0
is ProofVersion::Version1
, so the version should (probably) be bumped. The proof version is needed to verify the proof.. I can't find any documentation pointing to a link between a Versioned<Proof>
and ProofVersion
🤷 . Bare in mind this is for the "old" ID proofs and is not used for ID2.5 verifiable credentials so it probably will not be updated.
Have you worked with ID proofs versioned this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VERSION_0
for ProofVersion::Version1
and
VERSION_1
for ProofVersion::Version2
makes sense, so I am fine if we go with that.
fd531b5
to
ce0a497
Compare
Changes
Checklist
hard-to-understand areas.