Skip to content

Commit

Permalink
Upgrade dependencies and de-lint (#87)
Browse files Browse the repository at this point in the history
## Why are we doing this?
I was hoping to upgrade dependencies while doing #86, but the changes grew too large to combine with a feature so this is just a de-linting PR.

This upgrades to the pre-release 1.0 version of the org's Eslint config, which is much more closely aligned with the open source Airbnb config. Thus making progress towards #12 

## Did you document your work?

deviations from linting are documented with code comments.

## How can someone test these changes?

Steps to manually verify the change:

1. `npm i`
2. `npm t`

## What possible risks or adverse effects are there?

none

## What are the follow-up tasks?

none
  • Loading branch information
crccheck authored Jan 11, 2018
1 parent e77fb05 commit 359b68f
Show file tree
Hide file tree
Showing 9 changed files with 719 additions and 886 deletions.
5 changes: 4 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,8 @@ module.exports = {
extends: [
'@condenast/eslint-config-condenast/teams/partnerships',
'@condenast/eslint-config-condenast/rules/ext/mocha'
]
],
rules: {
'no-bitwise': ['error', { 'int32Hint': true }]
}
}
Loading

0 comments on commit 359b68f

Please sign in to comment.