Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a publicly accessible eslint config #12

Open
crccheck opened this issue Feb 21, 2017 · 3 comments
Open

Use a publicly accessible eslint config #12

crccheck opened this issue Feb 21, 2017 · 3 comments
Assignees
@crccheck
Labels
in progress

Comments

@crccheck
Copy link
Contributor

⬆️
@stripethree stripethree changed the title Use a publicly accessibly eslint config Use a publicly accessible eslint config Feb 21, 2017
@crccheck crccheck added this to the 1.0 milestone Feb 23, 2017
@crccheck
Copy link
Contributor Author

I'm just going to use airbnb since that's probably the closest popular opinionated config closest to ours

@crccheck crccheck added the ready label Feb 28, 2017
@crccheck crccheck self-assigned this Feb 28, 2017
@crccheck
Copy link
Contributor Author

crccheck commented Feb 28, 2017 •
edited
Loading

ok, even after disabling rules, I end up with:

✖ 125 problems (114 errors, 11 warnings)

I'm going to remove this from blocking the 1.0 release since it just affects dev deps of this project. For now, contributors can just not lint

@crccheck crccheck removed this from the 1.0 milestone Feb 28, 2017
@crccheck
Copy link
Contributor Author

crccheck commented Mar 1, 2017

my WIP https://github.com/CondeNast/launch-vehicle-fbm/compare/airbnb-eslint/%2312

@crccheck crccheck mentioned this issue Oct 18, 2017
Open
@crccheck crccheck mentioned this issue Jan 11, 2018
Merged
crccheck added a commit that referenced this issue Jan 11, 2018
@crccheck
Upgrade dependencies and de-lint (#87)
359b68f 
## Why are we doing this?
I was hoping to upgrade dependencies while doing #86, but the changes grew too large to combine with a feature so this is just a de-linting PR.

This upgrades to the pre-release 1.0 version of the org's Eslint config, which is much more closely aligned with the open source Airbnb config. Thus making progress towards #12 

## Did you document your work?

deviations from linting are documented with code comments.

## How can someone test these changes?

Steps to manually verify the change:

1. `npm i`
2. `npm t`

## What possible risks or adverse effects are there?

none

## What are the follow-up tasks?

none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crccheck crccheck

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crccheck