Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember to 4.0.x #25

Merged
merged 14 commits into from
Jan 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .babelrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"sourceType": "unambiguous",
"presets": [
[
"@babel/preset-env",
{
"targets": {
"chrome": 100
}
}
]
],
"plugins": []
}
5 changes: 5 additions & 0 deletions .changeset/warm-drinks-turn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'mx-ui-components': major
---

BREAKING: deps(misc): upgrade to ember 4.0 and bump ember-keyboard to latest version
3 changes: 3 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,7 @@
# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try
63 changes: 21 additions & 42 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,53 +7,32 @@ module.exports = {
ecmaVersion: 2018,
sourceType: 'module',
ecmaFeatures: {
legacyDecorators: true,
},
legacyDecorators: true
}
},
plugins: ['ember'],
extends: [
'eslint:recommended',
'plugin:ember/recommended',
'plugin:prettier/recommended',
],
extends: ['eslint:recommended', 'plugin:ember/recommended', 'plugin:prettier/recommended', 'plugin:storybook/recommended'],
env: {
browser: true,
browser: true
},
rules: {},
overrides: [
// node files
{
files: [
'./.eslintrc.js',
'./.prettierrc.js',
'./.template-lintrc.js',
'./ember-cli-build.js',
'./index.js',
'./testem.js',
'./blueprints/*/index.js',
'./config/**/*.js',
'./tests/dummy/config/**/*.js',
],
excludedFiles: [
'addon/**',
'addon-test-support/**',
'app/**',
'tests/dummy/app/**',
],
parserOptions: {
sourceType: 'script',
},
env: {
browser: false,
node: true,
},
plugins: ['node'],
extends: ['plugin:node/recommended'],
// node files
{
files: ['./.eslintrc.js', './.prettierrc.js', './.template-lintrc.js', './ember-cli-build.js', './index.js', './testem.js', './blueprints/*/index.js', './config/**/*.js', './tests/dummy/config/**/*.js'],
excludedFiles: ['addon/**', 'addon-test-support/**', 'app/**', 'tests/dummy/app/**'],
parserOptions: {
sourceType: 'script'
},
{
// Test files:
files: ['tests/**/*-test.{js,ts}'],
extends: ['plugin:qunit/recommended'],
env: {
browser: false,
node: true
},
],
};
plugins: ['node'],
extends: ['plugin:node/recommended']
}, {
// test files
files: ['tests/**/*-test.{js,ts}'],
extends: ['plugin:qunit/recommended']
}]
};
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Use Node
uses: actions/setup-node@v1
with:
node-version: '14'
node-version: '16'

- name: Install dependencies
run: yarn install --frozen-lockfile
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ build-storybook.log
# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/storybook-static
/.storybook/preview-head.html
/package-lock.json.ember-try
/yarn.lock.ember-try
4 changes: 4 additions & 0 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
/.eslintignore
/.eslintrc.js
/.git/
/.github/
/.gitignore
/.prettierignore
/.prettierrc.js
Expand All @@ -33,4 +34,7 @@
# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try
4 changes: 4 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,12 @@
/coverage/
!.*
.eslintcache
.lint-todo/

# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try
17 changes: 6 additions & 11 deletions .storybook/main.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
/* global module */

module.exports = {
stories: [
'../stories/**/*.stories.mdx',
'../stories/**/*.stories.@(js|jsx|ts|tsx)',
],
addons: [
'@storybook/addon-links',
'@storybook/addon-essentials',
'@storybook/addon-a11y',
'@storybook/addon-postcss',
],
};
stories: ['../stories/**/*.stories.mdx', '../stories/**/*.stories.@(js|jsx|ts|tsx)'],
addons: ['@storybook/addon-links', '@storybook/addon-essentials', '@storybook/addon-a11y', '@storybook/addon-postcss'],
core: {
builder: 'webpack5'
}
};
8 changes: 0 additions & 8 deletions .storybook/preview-head.html

This file was deleted.

64 changes: 0 additions & 64 deletions .travis.yml

This file was deleted.

2 changes: 1 addition & 1 deletion addon/modifiers/focus-on-render.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ import { modifier } from 'ember-modifier';

export default modifier(function focusOnRender(element) {
element.focus();
});
}, { eager: false });
3 changes: 2 additions & 1 deletion addon/modifiers/on-click-outside.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ export default modifier((element, [callback, outsideElementSelector], options) =
return () => {
outsideElement.removeEventListener('click', handleClick, options);
};
}
},
{ eager: false }
);
2 changes: 1 addition & 1 deletion app/modifiers/mox-copy-me.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ export default modifier(async (el, [id]) => {
return () => {
el.removeEventListener('click', copyToClipboard.bind(null, id), false);
};
});
}, { eager: false });
2 changes: 1 addition & 1 deletion app/modifiers/on-click-tag-input.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ export default modifier((element) => {
return () => {
element.removeEventListener('', handleEvent);
};
});
}, { eager: false });
2 changes: 1 addition & 1 deletion app/modifiers/on-select-tag.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ export default modifier((element, [callback]) => {
return () => {
element.removeEventListener('', runCallback);
};
});
}, { eager: false });
42 changes: 42 additions & 0 deletions config/deprecation-workflow.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/* eslint-disable no-undef */
self.deprecationWorkflow = self.deprecationWorkflow || {};
self.deprecationWorkflow.config = {
/* eslint-enable no-undef */
workflow: [
{ handler: 'throw', matchId: 'ember-global' },
{ handler: 'throw', matchId: 'ember.component.reopen' },
{ handler: 'throw', matchId: 'ember.built-in-components.import' },
{ handler: 'throw', matchId: 'ember.built-in-components.reopen' },
{
handler: 'throw',
matchId: 'deprecated-run-loop-and-computed-dot-access',
},
{ handler: 'throw', matchId: 'implicit-injections' },
{ handler: 'throw', matchId: 'route-render-template' },
{ handler: 'throw', matchId: 'manager-capabilities.modifiers-3-13' },
{
handler: 'throw',
matchId: 'ember.built-in-components.legacy-arguments',
},
{ handler: 'throw', matchId: 'ember-modifier.use-modify' },
{ handler: 'throw', matchId: 'ember-modifier.no-args-property' },
{ handler: 'throw', matchId: 'ember-modifier.no-element-property' },
{ handler: 'throw', matchId: 'autotracking.mutation-after-consumption' },
{ handler: 'throw', matchId: 'ember-modifier.function-based-options' },
{
handler: 'throw',
matchId: 'ember-keyboard.keyboard-first-responder-on-focus-mixin',
},
{
handler: 'silence',
matchId: 'ember-data:method-calls-on-destroyed-store',
},
{ handler: 'throw', matchId: 'ember-keyboard.first-responder-inputs' },
{ handler: 'throw', matchId: 'ember-keyboard.ember-keyboard-mixin' },
{ handler: 'throw', matchId: 'manager-capabilities.modifiers-3-13' },
{ handler: 'throw', matchId: 'autotracking.mutation-after-consumption' },
{ handler: 'throw', matchId: 'this-property-fallback' },
{ handler: 'throw', matchId: 'routing.transition-methods' },
{ handler: 'throw', matchId: 'ember-data:method-calls-on-destroyed-store' },
],
};
Loading