Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ember to 4.0.x #25

Merged
merged 14 commits into from
Jan 5, 2023
Merged

Update Ember to 4.0.x #25

merged 14 commits into from
Jan 5, 2023

Conversation

brettgoulder
Copy link
Contributor

What's this do?

Updates Ember to 4.0.x, along with the ember-keyboard dependency.

@changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 7008d21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mx-ui-components Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jayjayjpg
jayjayjpg reviewed Dec 21, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Test coverage: 92.29%

🚨 No before coverage could be loaded

1 similar comment
@github-actions
Copy link
Contributor

Test coverage: 92.29%

🚨 No before coverage could be loaded

jayjayjpg
jayjayjpg approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this change locally on the upgrade branch for platform-ui and this works great -- awesome work! ✨

@github-actions
Copy link
Contributor

Test coverage: 92.29%

🚨 No before coverage could be loaded

@github-actions
Copy link
Contributor

Test coverage: 92.29%

🚨 No before coverage could be loaded

@github-actions
Copy link
Contributor

Test coverage: 92.29%

🚨 No before coverage could be loaded

1 similar comment
@github-actions
Copy link
Contributor

Test coverage: 92.29%

🚨 No before coverage could be loaded

janelletavares
janelletavares approved these changes Dec 22, 2022
View reviewed changes
Copy link

@janelletavares janelletavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me

@github-actions
Copy link
Contributor

Test coverage: 92.29%

🚨 No before coverage could be loaded

@github-actions
Copy link
Contributor

Test coverage: 92.29%

🚨 No before coverage could be loaded

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Test coverage: 92.29%

🚨 No before coverage could be loaded

@brettgoulder brettgoulder merged commit 341ac94 into main Jan 5, 2023
@jayjayjpg jayjayjpg deleted the update-ember branch January 6, 2023 13:39
@jayjayjpg jayjayjpg mentioned this pull request Jan 6, 2023
Merged
@meroxa-machine meroxa-machine mentioned this pull request Jan 6, 2023
Merged
@jayjayjpg jayjayjpg mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg approved these changes

@janelletavares janelletavares janelletavares approved these changes

@dianadoherty dianadoherty Awaiting requested review from dianadoherty

@samirketema samirketema Awaiting requested review from samirketema

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brettgoulder @jayjayjpg @janelletavares