Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember to 4.0.x #25

Merged
merged 14 commits into from
Jan 5, 2023
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/warm-drinks-turn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'mx-ui-components': major
---

BREAKING: deps(misc): upgrade to ember 4.0 and bump ember-keyboard to latest version
3 changes: 3 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,7 @@
# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ module.exports = {
extends: ['plugin:node/recommended'],
},
{
// Test files:
// test files
files: ['tests/**/*-test.{js,ts}'],
extends: ['plugin:qunit/recommended'],
},
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ build-storybook.log
# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/storybook-static
/.storybook/preview-head.html
/package-lock.json.ember-try
/yarn.lock.ember-try
4 changes: 4 additions & 0 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
/.eslintignore
/.eslintrc.js
/.git/
/.github/
/.gitignore
/.prettierignore
/.prettierrc.js
Expand All @@ -33,4 +34,7 @@
# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try
4 changes: 4 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,12 @@
/coverage/
!.*
.eslintcache
.lint-todo/

# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try
64 changes: 0 additions & 64 deletions .travis.yml

This file was deleted.

2 changes: 1 addition & 1 deletion addon/modifiers/focus-on-render.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ import { modifier } from 'ember-modifier';

export default modifier(function focusOnRender(element) {
element.focus();
});
}, { eager: false });
3 changes: 2 additions & 1 deletion addon/modifiers/on-click-outside.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ export default modifier((element, [callback, outsideElementSelector], options) =
return () => {
outsideElement.removeEventListener('click', handleClick, options);
};
}
},
{ eager: false }
);
2 changes: 1 addition & 1 deletion app/modifiers/mox-copy-me.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ export default modifier(async (el, [id]) => {
return () => {
el.removeEventListener('click', copyToClipboard.bind(null, id), false);
};
});
}, { eager: false });
2 changes: 1 addition & 1 deletion app/modifiers/on-click-tag-input.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ export default modifier((element) => {
return () => {
element.removeEventListener('', handleEvent);
};
});
}, { eager: false });
2 changes: 1 addition & 1 deletion app/modifiers/on-select-tag.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ export default modifier((element, [callback]) => {
return () => {
element.removeEventListener('', runCallback);
};
});
}, { eager: false });
42 changes: 42 additions & 0 deletions config/deprecation-workflow.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/* eslint-disable no-undef */
self.deprecationWorkflow = self.deprecationWorkflow || {};
self.deprecationWorkflow.config = {
/* eslint-enable no-undef */
workflow: [
{ handler: 'throw', matchId: 'ember-global' },
{ handler: 'throw', matchId: 'ember.component.reopen' },
{ handler: 'throw', matchId: 'ember.built-in-components.import' },
{ handler: 'throw', matchId: 'ember.built-in-components.reopen' },
{
handler: 'throw',
matchId: 'deprecated-run-loop-and-computed-dot-access',
},
{ handler: 'throw', matchId: 'implicit-injections' },
{ handler: 'throw', matchId: 'route-render-template' },
{ handler: 'throw', matchId: 'manager-capabilities.modifiers-3-13' },
{
handler: 'throw',
matchId: 'ember.built-in-components.legacy-arguments',
},
{ handler: 'throw', matchId: 'ember-modifier.use-modify' },
{ handler: 'throw', matchId: 'ember-modifier.no-args-property' },
{ handler: 'throw', matchId: 'ember-modifier.no-element-property' },
{ handler: 'throw', matchId: 'autotracking.mutation-after-consumption' },
{ handler: 'throw', matchId: 'ember-modifier.function-based-options' },
{
handler: 'throw',
matchId: 'ember-keyboard.keyboard-first-responder-on-focus-mixin',
},
{
handler: 'silence',
matchId: 'ember-data:method-calls-on-destroyed-store',
},
{ handler: 'throw', matchId: 'ember-keyboard.first-responder-inputs' },
{ handler: 'throw', matchId: 'ember-keyboard.ember-keyboard-mixin' },
{ handler: 'throw', matchId: 'manager-capabilities.modifiers-3-13' },
{ handler: 'throw', matchId: 'autotracking.mutation-after-consumption' },
{ handler: 'throw', matchId: 'this-property-fallback' },
{ handler: 'throw', matchId: 'routing.transition-methods' },
{ handler: 'throw', matchId: 'ember-data:method-calls-on-destroyed-store' },
],
};
25 changes: 13 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,10 @@
"build-storybook": "yarn run build:prod --"
},
"dependencies": {
"ember-auto-import": "^2.5.0",
"ember-cli-babel": "^7.26.10",
"ember-cli-htmlbars": "^5.7.2",
"ember-keyboard": "6.0.4",
"ember-cli-htmlbars": "^6.1.1",
"ember-keyboard": "8.2.0",
"ember-named-blocks-polyfill": "^0.2.4",
"ember-root-url": "^1.0.0"
},
Expand Down Expand Up @@ -70,10 +71,10 @@
"chromatic": "^6.2.1",
"core-js": "^3.9.1",
"ember-a11y-testing": "^4.0.6",
"ember-auto-import": "^1.12.0",
"ember-cli": "~3.28.5",
"ember-cli": "~4.0.1",
"ember-cli-code-coverage": "^1.0.2",
"ember-cli-dependency-checker": "^3.2.0",
"ember-cli-deprecation-workflow": "^2.1.0",
"ember-cli-inject-live-reload": "^2.1.0",
"ember-cli-postcss": "^7.0.0",
"ember-cli-sri": "^2.1.1",
Expand All @@ -82,31 +83,31 @@
"ember-disable-prototype-extensions": "^1.1.3",
"ember-export-application-global": "^2.0.1",
"ember-load-initializers": "^2.1.2",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-modifier": "^3.1.0",
"ember-page-title": "^6.2.2",
"ember-page-title": "^7.0.0",
"ember-qunit": "^5.1.5",
"ember-resolver": "^8.0.3",
"ember-source": "~3.28.8",
"ember-source": "~4.0.1",
"ember-source-channel-url": "^3.0.0",
"ember-template-lint": "^3.15.0",
"ember-tooltips": "^3.5.1",
"ember-truth-helpers": "^3.0.0",
"ember-try": "^1.4.0",
"ember-try": "^2.0.0",
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-ember": "^10.5.8",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^3.4.1",
"eslint-plugin-qunit": "^6.2.0",
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-qunit": "^7.2.0",
"loader.js": "^4.7.0",
"npm-run-all": "^4.1.5",
"postcss-import": "^14.0.2",
"prettier": "^2.5.1",
"qunit": "^2.17.2",
"qunit-dom": "^1.6.0",
"qunit-dom": "^2.0.0",
"sinon": "^9.2.4",
"tailwindcss": "^3.0.22"
"tailwindcss": "^3.0.22",
"webpack": "^5.75.0"
},
"engines": {
"node": ">= 12.20.* || 14.* || >= 16"
Expand Down
2 changes: 1 addition & 1 deletion tests/dummy/config/ember-cli-update.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"packages": [
{
"name": "ember-cli",
"version": "3.28.5",
"version": "4.0.1",
"blueprints": [
{
"name": "addon",
Expand Down
15 changes: 0 additions & 15 deletions tests/dummy/config/targets.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,6 @@ const browsers = [
'last 1 Safari versions',
];

// Ember's browser support policy is changing, and IE11 support will end in
// v4.0 onwards.
//
// See https://deprecations.emberjs.com/v3.x#toc_3-0-browser-support-policy
//
// If you need IE11 support on a version of Ember that still offers support
// for it, uncomment the code block below.
//
// const isCI = Boolean(process.env.CI);
// const isProduction = process.env.EMBER_ENV === 'production';
//
// if (isCI || isProduction) {
// browsers.push('ie 11');
// }

module.exports = {
browsers,
};
Loading