Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connatix viewability support #7

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Connatix viewability support #7

wants to merge 7 commits into from

Conversation

rares-mihai-preda
Copy link
Collaborator

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

rares-mihai-preda pushed a commit that referenced this pull request Aug 8, 2024
@os-solta
kimberliteBidAdapter: video media type support (prebid#11981)
40b906d 
* Kimberlite bid adapter (#1)

* initial: bid adapter

* styling

* Fix: lint (#2)

* Fix: lint (#4)

* review fixes (#6)

* Change: filling request.ext.prebid section (#7)

* Video support

* Fix: tests

* Adapter's version update

* No video defaults
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

DarianAvasan
DarianAvasan approved these changes Aug 8, 2024
View reviewed changes
Copy link

@DarianAvasan DarianAvasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/connatixBidAdapter.js (+1 error)

@rares-mihai-preda @dgirardi
implement viewability support
3bf8b41 
openxBidAdapter remove PAF, bugfix  ortbConverter response (prebid#12105)

Appnexus Bid Adapter: fix parse of the encoded string to check for ast_override_div argument (prebid#12106)

Richaudience Bid Adapter : add compability with DSA (prebid#12099)

* Update richaudienceBidAdapter.md

Update maintainer e-mail to integrations@richaudience.com

* Add richaudienceBidAdapter.js file

* Add richaudienceBidAdapter_spec.js

* Update richaudienceBidAdapter.js

* RichaudienceBidAdapter add compability with DSA

* RichaudienceBidAdapter add compability with DSA

* RichaudienceBidAdapter add compability with DSA

---------

Co-authored-by: Patrick McCann <pmccann@cafemedia.com>
Co-authored-by: sergigimenez <sergi.gim@gmail.com>

finish unit testing

added container identifier for viewability on bid params

Add new TGM adapter (prebid#12100)

Co-authored-by: apykhteyev <alex@project-limelight.com>

Prebid 9.9.0 release

Increment version to 9.10.0-pre

deprecate old copper6 alias (prebid#12112)

LimelightDigital Adapter: Add support of ortb2 and ortb2Imp objects (prebid#12078)

* Add support of ortb2 and ortb2Imp objects

* Fix tests

* Fix tests

---------

Co-authored-by: apykhteyev <alex@project-limelight.com>

update configuration example (prebid#12109)

FPD Enrichment: Replace device values `w` and `h` with screen size; add `ext.vpw` and `ext.vph` (prebid#12108)

Core: fix broken native resizing (prebid#12096)

* Core: fix broken native resizing

* fix test

Weborama RTD Module: BUGFIX on user-centric profile validation (prebid#12095)

* update unit tests

* fix code and doc

* improve integration example

* add extra test

* improve logging

* fix lint issues

hotfix - after this I will fix all tests

fix

fix width and height

fix iframe detection

change detected viewability between 0 and 1 to be consistent with declared viewability

improve the case case where the publisher doesn't send us a container id to check viewability

fully covered by tests

fix test that works local

re-use percentInView method

fix unit tests

removed test

Revert "removed test"

This reverts commit 15dcab7.

Anyclip Bid Adapter : refactor bid adapter (prebid#12030)

* update anyclip adapter

* remove coppa

* fix jsdoc warnings

* create bidderUtils

* delete duplicate code

* refactor

---------

Co-authored-by: Chucky-choo <dedafu47@gmail.com>

Digital Matter Bid Adapter: initial release (prebid#12114)

* update anyclip adapter

* remove coppa

* fix jsdoc warnings

* create bidderUtils

* delete duplicate code

* refactor

* add digitalMatter Bid Adapter

---------

Co-authored-by: Chucky-choo <dedafu47@gmail.com>

IX Bid Adapter: Remove client FT pbjs_allow_all_eids (prebid#12117)

Co-authored-by: Sajid Mahmood <sajid.mahmood@indexexchange.com>

SeedingAlliance Adapter: rework to properly use openRTB standard internally (prebid#12101)

* rework adapter to only use openRTB data internally

* added comments

* fix lint errors

saambaaBidAdapter.js:  make alias of advangelist (prebid#11992)

* saambaaBidAdapter.js: reuse repeated code block

* Update saambaaBidAdapter.js

* Update advangelistsBidAdapter.js

* Update saambaaBidAdapter.js

* Update advangelistsBidAdapter.js

* Update saambaaBidAdapter.js

* Update advangelistsBidAdapter.js

* Create index.js

* Update saambaaBidAdapter.js

* Update advangelistsBidAdapter.js

* Update index.js

* Update advangelistsBidAdapter.js

* Update saambaaBidAdapter.js

* Update index.js

* Update advangelistsBidAdapter.js

* Update saambaaBidAdapter.js

* Update index.js

* Update advangelistsBidAdapter.js

* Update saambaaBidAdapter.js

* Update advangelistsBidAdapter.js

* Delete modules/saambaaBidAdapter.js

* Update advangelistsBidAdapter.js

* Update beachfrontBidAdapter.js

* Update beachfrontBidAdapter.js

* Update beachfrontBidAdapter.js

* Update nextrollBidAdapter.js

* Update beachfrontBidAdapter.js

* Update index.js

* Update advangelistsBidAdapter.js

* Update beachfrontBidAdapter.js

* Create saambaaBidAdapter.js

* fix file name

---------

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

Prebid 9.10.0 release

Increment version to 9.11.0-pre

Core: make sure adUnitCodes are unique in auction events (prebid#12127)

Mobian RTD provider: update API endpoint (prebid#12121)

* update API endpoint for mobian RTD provider

* lint mobian RTD provider

Initial Commit for Symitri Analytics Adapter (prebid#12132)

Co-authored-by: Manan <manan.patel@intersection.com>

Djax Bid Adapter : initial release (prebid#12120)

* Djax bid adapter files added

* fix linting issue

* Linting issue fixed

* Update djaxBidAdapter.js

* Update djaxBidAdapter_spec.js

* Update djaxBidAdapter_spec.js

---------

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Co-authored-by: Patrick McCann <pmccann@cafemedia.com>

Preciso : Added new library to remove code duplication in bid adapter (prebid#11868)

* Preciso : Added new library to remove code duplication in bid adapter

* modified bidfloor mapping logic

* error fix

* error fix

* import bidUtils.js in IdxBidadapter to reduce the code duplicataion

* import bidUtils.js in IdxBidadapter to reduce the code duplicataion

* Error fix

* Imported bidUtils library into redtram bid adapter

* import common library in mediabramaBidAdapter

* import common library in loganBidAdapter to remove code duplication

* removed storageManaser from library

* renderer.js changes reverted

33across - allow aliasing (prebid#12138)

Updating isBidRequestValid logic to account for aliasing of bidder names (prebid#12136)

Digitalmatter Bid Adapter : add dichange alias (prebid#12133)

* add alias

* fix alias

---------

Co-authored-by: Chucky-choo <dedafu47@gmail.com>

add media consortium adapter (prebid#11892)

Co-authored-by: Maxime Lequain <maxime.lequain@gmail.com>

UserID: merge EIDs with first party data (prebid#12110)

* ortbConverter: do not override EIDS provided as first party data

* update tests

* Allow bidder-specific FPD enrichments

* Refactor eid generation, add primaryIds

* EIDs as FPD

* Fix tests

* PBS tests, fix multiple hook registration

* Fix more test cleanup

* remove eidPermissions

* refactor oderByPriority

* refactor initializedSubmodules

* fix lint

* update id5 primaryIds

* simplify eid source filtering

* clean up PBS userId logic

* Revert "Allow bidder-specific FPD enrichments"

This reverts commit 2fb7452.

* undo bidder-specific enrichments

* use startAuction instead of requestBids

* add test on userIdAsEids

* Fix lint

Bump ws, @wdio/browserstack-service, @wdio/cli and @wdio/local-runner (prebid#12148)

Bumps [ws](https://github.com/websockets/ws) to 8.17.1 and updates ancestor dependencies [ws](https://github.com/websockets/ws), [@wdio/browserstack-service](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-browserstack-service), [@wdio/cli](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-cli) and [@wdio/local-runner](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-local-runner). These dependencies need to be updated together.

Updates `ws` from 8.13.0 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.13.0...8.17.1)

Updates `@wdio/browserstack-service` from 8.39.0 to 9.0.5
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.5/packages/wdio-browserstack-service)

Updates `@wdio/cli` from 8.39.0 to 9.0.5
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.5/packages/wdio-cli)

Updates `@wdio/local-runner` from 8.39.0 to 9.0.5
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.5/packages/wdio-local-runner)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: "@wdio/browserstack-service"
  dependency-type: direct:development
- dependency-name: "@wdio/cli"
  dependency-type: direct:development
- dependency-name: "@wdio/local-runner"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Smartadserver Bid Adapter : add DSA support (prebid#12141)

* add support of dsa

* restore topics

* DSA fix for UT

Change consent default param name (prebid#12154)

Co-authored-by: Danijel Ristic <danijel-ristic@target-video.com>

Freedom Ad Network Bid Adapter: initial release (prebid#12153)

* Create fanAdapter.md

* Create fanAdapter.js

* Create fanAdapter_spec.js

* Update fanAdapter_spec.js

* Update fanAdapter.js

* Update fanAdapter.js

* Update fanAdapter_spec.js

* Update fanAdapter.js

* Update fanAdapter_spec.js

* Update fanAdapter.js

* Update fanAdapter_spec.js

* Update fanAdapter.js

* Update fanAdapter_spec.js

* Update fanAdapter.js

* Update fanAdapter.js

deleted bidder name check (prebid#12157)

Co-authored-by: Octavia Suceava <octaviasuceava@Octavias-MacBook-Pro.local>

Connatix Bid Adapter : support eids (prebid#12142)

* add eids on request

* change naming

---------

Co-authored-by: Darian Avasan <darian.avasan@connatix.com>
Co-authored-by: Octavia Suceava <octaviasuceava@Octavias-MacBook-Pro.local>

PrebidServer Bid Adapter : update to use gloablly defined alias or s2sConfig defined alias (prebid#12159)

* update to use gloablly defined alias or s2sConfig defined alias

* Add test case

---------

Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarianAvasan DarianAvasan DarianAvasan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rares-mihai-preda @DarianAvasan