-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kimberliteBidAdapter: video media type support #11981
Conversation
Hi! I'm not sure about the reason of CI build fail. Could someone help me with the reason please? |
Just a flaky test, no worries |
modules/kimberliteBidAdapter.js
Outdated
if (imp[VIDEO]) { | ||
deepSetValue(imp, 'video.linearity', mediaTypes[VIDEO].linearity || 1); | ||
deepSetValue(imp, 'video.protocols', mediaTypes[VIDEO].protocols || [3, 6]); | ||
deepSetValue(imp, 'video.placement', mediaTypes[VIDEO].placement || 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ortb convertor gives you all these for free, no need to copy them. Is that correct @dgirardi ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is to set default values, which the library does not provide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see @os-solta these defaults aren't good guesses, you're better off requiring the publisher make a choice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like i'll just skip these defaults here, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Video defaults on placement and startdelay
modules/kimberliteBidAdapter.js
Outdated
if (imp[VIDEO]) { | ||
deepSetValue(imp, 'video.linearity', mediaTypes[VIDEO].linearity || 1); | ||
deepSetValue(imp, 'video.protocols', mediaTypes[VIDEO].protocols || [3, 6]); | ||
deepSetValue(imp, 'video.placement', mediaTypes[VIDEO].placement || 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see @os-solta these defaults aren't good guesses, you're better off requiring the publisher make a choice
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter kimberliteBidAdapter: video support docs update prebid.github.io#5504
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Added video media type to kimberliteBidAdapter
Other information