forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebid 9.15.0 #201
Merged
Merged
Prebid 9.15.0 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fallsback * improves error messaging * updates div id name * adds tests
* adding gvlid during submodule registration * updated docs * review comment: import type to prevent warning --------- Co-authored-by: Pavlo <pavlo@id-ward.com>
* fix(permutiveRtd): transform integers to strings * docs(permutiveRtd): update jsdoc to match function signatures * docs(permutiveRtd): fix ordering of jsdoc comments
The utiq module uses busy waiting to provide the `eid` values. Every busy waiting round it logs messages that are not actionable.
…id#11917) * Implement functionality for deal priority * Update test cases * kick off test manually * Added support of GPP to PubMatic adapter * gpp_sid in user syncs supposed to encode as a string, not an array * Remove extra space * Remove trailing spaces * Remove the placement parameter and update test cases accordingly, Add plcmt parameter. * Supporting placement parameter and logging warning message, for the plcmt parameter, if it is missing. * Remove commented code * Added plcmt in the pubmaticBidAdapter.md file * Adding support for Banner battr object * reading battr from ortb2Imp.banner --------- Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
prebid#11425) * PTOW-2; updates to the pubx analytics adapter * PTOW-2 review actions * PTOW-2 Review actions * PTOW-2 updating pubx.ai analytics version * remove empty line * linting changes * PTOW-2; updates to the pubx analytics adapter * PTOW-2 review actions * PTOW-2 Review actions * PTOW-2 updating pubx.ai analytics version * PTOW-2 resolving conflicts * PTOW-2-fix-linting-errors * PTOW-2 fixing tests * fixing bugs, modifying blob behaviour, addressing browser compatibility * add source field * switching from sessionStorage to localStorage * fixing tests * modifying functions to avoid prebid duplication checker * implementing enums * moving user agent code to libraries * updated return types * switching to macro substitution for prebid version * adding centralised sendBeacon wrapper * 'fixing' tests --------- Co-authored-by: Nathan Oliver <nathanoliver@Nathans-MacBook-Pro.local> Co-authored-by: tej656 <tej@pubx.ai> Co-authored-by: Tej <139129627+tej656@users.noreply.github.com> Co-authored-by: nathan-pubx <157742646+nathan-pubx@users.noreply.github.com>
…access && bugfixes: unauthorized storage access (prebid#11884) * relevatehealthBidAdapter.js: bugfix for storage used without consent * Update index.js * Update index.js * Update index.js * Update index.js * Update index.js * Update index.js * Update index.js * Update index.js * Update relevatehealthBidAdapter.js * Update index.js * Update index.js * Update index.js * Update index.js * Update index.js * Update .eslintrc.js * Update index.js * Update relevatehealthBidAdapter.js * Update 33acrossAnalyticsAdapter.js * Update index.js * Update index.js * Update 33acrossAnalyticsAdapter.js * Update index.js * Update ampliffyBidAdapter.js * Update index.js * Update invibesBidAdapter.js * Update growthCodeAnalyticsAdapter.js * Update fintezaAnalyticsAdapter.js * Update growthCodeAnalyticsAdapter.js * Update etargetBidAdapter.js * Update dspxBidAdapter.js * Update cwireBidAdapter.js * Update cwireBidAdapter.js * Update ampliffyBidAdapter.js * Update etargetBidAdapter.js * Update dspxBidAdapter.js * Update fintezaAnalyticsAdapter.js * Update ampliffyBidAdapter.js * Update adlooxAnalyticsAdapter.js * Update invibesBidAdapter.js * Update fintezaAnalyticsAdapter.js * Update dspxBidAdapter.js * Update connectIdSystem.js * Update automatadAnalyticsAdapter.js * Update sonobiBidAdapter.js * Update contxtfulRtdProvider.js * Update sonobiBidAdapter.js * Update contxtfulRtdProvider.js * Update index.js * Update cleanioRtdProvider.js * Update connectIdSystem.js * Update geoedgeRtdProvider.js * Update growthCodeRtdProvider.js * Update sirdataRtdProvider.js * Update sirdataRtdProvider.js * Update contxtfulRtdProvider_spec.js * Update contxtfulRtdProvider_spec.js * Update index.js Fix duplication * Update index.js * refactor custom linter rules * use TODO and comments instead of quietly removing rule-breaking code * Add linter GH action * Fix linter workflow name * Run npm ci on linter check * Filter out missing (new) files * Do not fail on linter failure * swap continue-on-error * remove spurious condition * Improve comment * Fix links for duplication checker comments * Filter out negative deltas * Update linter warning comment * Update .eslintrc.js --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
* feat(isBidRequestValid): just filter token once. not filter publisher and tagid * feat(isBidRequestValid): add unit test * feat(spec): fix eslint * feat(spec): fix unit test * feat(spec): fix unit test * feat(ext): change default value * feat(utm): build UTMTag data * feat(spec): fix utm test * feat(utm): get UTMTag * feat(utm): add unit tests * feat(utm): fix unit tests * feat(utm): fix unit tests * feat(utm): fix unit tests * feat(ext): add ids * feat(ext): fix unit test * feat(code style): extra common utils * feat(code style): extra common utils * feat(code style): extra common utils --------- Co-authored-by: yubei01 <yubei01@baidu.com>
* Update README.md update * Add admixerwl alias for admixerBidAdapter. * admixer change endpointId to tagId --------- Co-authored-by: AdmixerTech <35560933+AdmixerTech@users.noreply.github.com> Co-authored-by: AdmixerTech <admin@admixer.net> Co-authored-by: Yaroslav Masenko <intgr-user@admixer.ua> Co-authored-by: Daria Boyko <dboyko@admixer.com>
…rebid#11924) * passing uidsAsEids in adapter and log refactor * Changes: removed sendBeacon() and added keepalive = true option for ajax. --------- Co-authored-by: adish.r <adish.r@media.net> Co-authored-by: akshat.v <akshat.v@media.net>
* upgrade prebid js * added conversantBidAdapter * added criteoBidAdapter, tripleliftBidAdapter, pulsepointBidAdapter * adtelligent bid adapter * remove oneVideoBidAdapter from modules.json * added yieldmo bid adapter * build:connatix script * removed flocIdSystem & TrustxBidAdapter from modules.json * added aniview bid adapter * moved line * added nextMillennium adapter to modules.json * newline at the end of the file * added new adapters * added minutemedia adapter * added richaudience adapter * Revert "added richaudience adapter" This reverts commit d87cb0d. * Revert "added minutemedia adapter" This reverts commit ac53dff. * Added Permutive RTD module * comma * [feat] add sharethroughBidAdapter * Add consentManagementGpp module * fix gpp signal (#5) * remove gpp module because no need to support it yet * LiveRamp submodule identityLink * added sonobi bid adapter * upgrade to prebid 8.17.0 * added pgamsspBidAdapter because its alias was removed from adtelligentBidAdapter in 8.x.0 * added ozone as Connatix bidder partner * added showheroes adapter * added seedtag bid adaptor * added minutemedia * removed duplicated minute media * added sovrn bid adapter * fix: add consentManagementGpp module * added new build and gannet adapters * renamed build command * added specific modules for gannett * added kueezRtb bid adaptor * added video media type support for connatix bid adapter * added all the recommended params to video media type mock * improved validateVideo function * impreoved validateVideo function once again:) * removed redundant checks in bid request validation * clarified test it statement * improved unit tests * updated validateVideo function * removed modules.json * removed connatix build script --------- Co-authored-by: Rares Mihai Preda <rares.preda@connatix.com> Co-authored-by: Darian <darian.avasan@connatix.com> Co-authored-by: alexandru.calauz <alexandru.calauz@connatix.com> Co-authored-by: cosminser <80513728+cosminser@users.noreply.github.com> Co-authored-by: Gaina Dan <dan.gaina@connatix.com> Co-authored-by: Cristi Silav <cristian.silav@connatix.com> Co-authored-by: mariusszabo <33828291+mariusszabo@users.noreply.github.com> Co-authored-by: Marius Szabo <marius.szabo@connatix.com> Co-authored-by: Octavia Suceava <octavia.suceava@connatix.com> Co-authored-by: Marius Potor <marius.potor@connatix.com>
…rebid#11775) * Azerion Edge RTD Module: Initial release ### Type of change [x] Feature: New RTD Submodule ### Description of change Adds new Azerion Edge RTD module. Maintainer: azerion.com Contact: @garciapuig @mserrate @gguridi * Azerion Edge RTD Module: Initial release. Typo * AzerionEdge RTD Module: Documentation: Required parameters Type of change: Documentation/Feature Description of change: Specifying new required parameters on documentation. Updating examples. * AzerionEdge RTD Module: Compatible with GDPR/USP Privacy Modules (#14) - Added GDPR validation. - We validate against ImproveDigital vendor ID consent and several purposes. - We don't load edge script, nor process the existing data, if consent wasn't given. - Adding support for USP consent. * AzerionEdgeRTDModule: Passing the consent to the script execution (#17) Adding GVL ID to the module configuration Passing the consent to the script execution instead of handling it in prebid (#16) --------- Co-authored-by: Gorka Guridi <gorka.guridi@azerion.com> --------- Co-authored-by: Gorka Guridi <gorka.guridi@gmail.com>
* init adapter * add gpp support * upd * add userSync
Co-authored-by: QuentinGallard <quentin.gallard@digitalnolimit.com>
* Adkernel Bid Adapter: add voisetech alias * Adkernel Bid Adapter: add voisetech alias
…prebid#11926) * check if the body is available * fix linter errors * Add integ test * Re-check if frame is already present * But do it better --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
* DSPx Bid Adapter: add ortb2 content, topics support DSPx Bid Adapter: add ortb2 content, topics support * DSPx Bid Adapter: add ortb2 content, topics support --------- Co-authored-by: avj <avj8383@gmail.com>
* IntentIQ Analytics Module * update intentiq analytics adapter * remove percentage and change group * update analytics adapter and tests * updated flow * remove 'this' * rename privacy parameter * add callback timeout * Extract only used parameters from CryptoJS * add new unit tests * change callback timeout order * added tests and small fixes * change saving logic * support "html5" and "cookie" storage types * support storage type, update flow * add documentation * small updates * IntentIQ Analytics Module * Multiple modules: clean up unit tests (prebid#11630) * Test chunking * update some bidder eid tests * split eid tests into each userId submodule * cleanup userId_spec * add TEST_PAT config * fix idx, lmp * clean up userId_spec * fix double run, invibes, intentIq * small fixes * undo package-lock changes * update colors, remove empty test * 8pod analytics: clean up interval handler * update intentiq analytics adapter * undo unnecessary changes * undo change by mistake * update params and documentation * turn back storage clearing * fix linter error * fix wording and spelling mistakes * change test to handle full url to check other ids not reported --------- Co-authored-by: Eyvaz <62054743+eyvazahmadzada@users.noreply.github.com> Co-authored-by: Eyvaz Ahmadzada <eyvaz.ahmedzade.12@gmail.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
…on storage (prebid#11928) * feat: sessionstorage in storagemanager * fix: use storage manager * fix: lint * fix: storage from rtd * doc: no changes needed * refactor storageManager/sessionStorage --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
* Validation module: jsdoc fixes * Update eids.js * Update eids.js * Update index.js
* Initial version of AdvRed analytics adapter * Initial version of AdvRed analytics adapter
…ing cookie (prebid#11950) * Dailymotion Bid Adapter: add consent enforcement to read the advertising cookie * [x] Feature * Add consent enforcement before reading the advertising cookie * If Dailymotion does not have consent from the user, it does not transmit any cookie in the request to the Prebid server (previously the cookie was sent but not used) * Dailymotion Bid Adapter: no fallback for startdelay and plcmt * Dailymotion Bid Adapter: more concise cookie enforcement --------- Co-authored-by: Sébastien Millet <sebastien.millet@dailymotion.com> Co-authored-by: Kevin Siow <kevin.siow@dailymotion.com>
* Add video support * Refactor code to library * Fix lint errors * Fix code duplication * Fix lint errors --------- Co-authored-by: Danijel Ristic <danijel-ristic@target-video.com>
…g consent preferences (prebid#12224)
* Adding useBaseGvlid to aliasBidAdapter * refactor --------- Co-authored-by: Marcin Komorski <marcinkomorski@Marcins-MacBook-Pro.local>
* packages update to remove vulnerabilities * wdio.shared.conf.js: update mocha compiler to new babel-register module
…better way. (prebid#12263) * send BidRejected Events to capture floored bids * fix tests * send pubx_id as query param * added extraData in analytics adapter to be sent in beacon data * added extraData in analytics adapter to be sent in beacon data * moved data read to session storage * bumped version * moving all data to localStorage again * updated test cases for pubxaiAA.js * fixing the missing logging of invalid bids --------- Co-authored-by: tej656 <tej@pubx.ai> Co-authored-by: Tej <139129627+tej656@users.noreply.github.com> Co-authored-by: NikhilX <nikhil@pubx.ai> Co-authored-by: Nathan Oliver <nathanoliver@Nathans-MacBook-Pro.local>
* userId: fix unhandled rejection from refreshUserIds * apply same treatment to getEncryptedEidsForSource
* Digital Matter Bid Adapter: Refactor Adapter * Digital Matter Bid Adapter: add aliases
* POC test * fix tests + a bug in log * removed appnexus newly added events and logs * use constants for events * prepared POC for PrebidJS official * code review * refactor * set viewability container to hba to determine if we cannot detect vieweability or the publisher does not sent us the viewability container id * set context and added two clear TODOs with what it remains to be considered done * Connatix Bid Adapter: Support Events * rename constant name * refactor * adapt the previous solution to the new one suggested by PrebidJs team * unit tests * test * fix unit tests * more unit tests * added bid id on bid won event * conficts * fix find a bid by alias and include tests
* mark bids with deferRendering / deferBilling * refactor internals of triggerBilling * deferred rendering * trigger deferred render from triggerBilling * Fix dfp gdpr parameter dupes
* prebid#11838 send beacon fix * Update cwireBidAdapter.js * Update 33acrossAnalyticsAdapter.js --------- Co-authored-by: Marcin Komorski <marcinkomorski@Marcins-MacBook-Pro.local> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
…en a publisher opts in (prebid#12267) * Update ozoneBidAdapter_spec.js * Update ozoneBidAdapter.js * Update ozoneBidAdapter_spec.js * Update ozoneBidAdapter_spec.js * Update ozoneBidAdapter.js updated device object values to come from ortb.device
* feat: added bid floor support in DI adapter * refactor: add common ortb video params to deepintentUtils file * refactor: replace common ortb video params for deepintent and sovrn bid adapters * refactor: add formatResponse function to deepintentUtils file * refactor: replace common formatResponse function for deepintent and relevatehealth bid adapters * feat: bid floor should be passed if it is set to 0 explicitly * fix: add a new line at the end of deepintentUtils file --------- Co-authored-by: Atharva Jangada <atharva.jangada@deepintent.com>
AnatoliiBaidaFS
commented
Oct 11, 2024
@@ -10,12 +10,11 @@ | |||
"concertBidAdapter", | |||
"connectIdSystem", | |||
"consentManagementUsp", | |||
"consentManagement", | |||
"consentManagementTcf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been changed from consentManagement to consentManagementTfc in Prebid 9.0
AnatoliiBaidaFS
commented
Oct 11, 2024
"conversantBidAdapter", | ||
"criteoBidAdapter", | ||
"criteoIdSystem", | ||
"dfpAdServerVideo", | ||
"enrichmentFpdModule", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been removed in Prebid 9.0
aecook
approved these changes
Oct 14, 2024
Merged
aecook
added a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information