Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure no unexpected trailing data for all message types #150

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Ensure no unexpected trailing data for all message types #150

merged 2 commits into from
Oct 20, 2022

Conversation

jtraglia
Copy link
Contributor

PR Description

Noticed that FindNodeMessage called RlpUtil#checkComplete but the other message types did not.

  • Call RlpUtil.checkComplete(reader) after reading all expected values.
  • For consistency:
    • Rename listReader -> reader in FindNodeMessage.
    • Remove number (1) from end of variable names.

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ajsutton
ajsutton approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ajsutton ajsutton merged commit 6f9e9e7 into Consensys:master Oct 20, 2022
@jtraglia jtraglia mentioned this pull request Oct 20, 2022
Merged
@jtraglia jtraglia deleted the call-check-complete branch November 3, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtraglia @CLAassistant @ajsutton